Skip to content

Prefer older version of jsonschema without Rust dependency#390

Merged
t1m0thyj merged 6 commits intomainfrom
test/remove-rust-deps
Mar 30, 2026
Merged

Prefer older version of jsonschema without Rust dependency#390
t1m0thyj merged 6 commits intomainfrom
test/remove-rust-deps

Conversation

@t1m0thyj
Copy link
Copy Markdown
Member

@t1m0thyj t1m0thyj commented Mar 27, 2026

What It Does

Partially addresses #388.

jsonschema 4.18.0 replaced a pure C dep with a Rust-based one that is uninstallable on z/OS - see python-jsonschema/jsonschema#1117.

Downgrading jsonschema to 4.17.3 resolves the dependency issue, but is not supported in Py3.14 and above.

Until we have time in the future to investigate a replacement for jsonschema, the best solution seems to be making the jsonschema version conditional based on Python version, and documenting that Py3.14 is not supported on z/OS.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Audit check is failing on pygments which is a dev dep used for building docs and has no published fix yet.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Mar 27, 2026
@zowe-robot zowe-robot moved this from New Issues to In Progress in Zowe CLI Squad Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.13%. Comparing base (1bd1b1e) to head (6f571bc).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   82.13%   82.13%           
=======================================
  Files          49       49           
  Lines        2916     2916           
=======================================
  Hits         2395     2395           
  Misses        521      521           
Flag Coverage Δ
unittests 82.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj marked this pull request as ready for review March 27, 2026 12:51
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe CLI Squad Mar 27, 2026
Comment thread README.md Outdated
Co-authored-by: anaxceron <ana.ceron@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link
Copy Markdown
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for adding the warning 🙏

Copy link
Copy Markdown
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Timothy for the fix

@t1m0thyj t1m0thyj merged commit b4f0611 into main Mar 30, 2026
22 of 23 checks passed
@t1m0thyj t1m0thyj deleted the test/remove-rust-deps branch March 30, 2026 18:01
@github-project-automation github-project-automation bot moved this from Review/QA to Closed in Zowe CLI Squad Mar 30, 2026
@github-actions
Copy link
Copy Markdown

Release succeeded for the main branch. 🎉

The following packages have been published:

  • pypi: zowe_core_for_zowe_sdk-1.0.0.dev26
  • pypi: zowe_python_sdk_bundle-1.0.0.dev26
  • pypi: zowe_workflows_for_zowe_sdk-1.0.0.dev26
  • pypi: zowe_zos_console_for_zowe_sdk-1.0.0.dev26
  • pypi: zowe_zos_files_for_zowe_sdk-1.0.0.dev26
  • pypi: zowe_zos_jobs_for_zowe_sdk-1.0.0.dev26
  • pypi: zowe_zos_tso_for_zowe_sdk-1.0.0.dev26
  • pypi: zowe_zosmf_for_zowe_sdk-1.0.0.dev26

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

5 participants