Conversation
filepath.Walk does not follow symlinks, so symlinked scripts were invisible to help listings, exec, and tab completion. Extract collectExecutables from the help command and resolve symlinks via os.Stat before checking executable bits. Broken symlinks are silently skipped. Also adds self-documenting help target to Makefile. EARS: SYMLINK-001 through SYMLINK-006
Owner
Author
|
Closes #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filepath.Walk does not follow symlinks, so symlinked scripts were
invisible to help listings, exec, and tab completion. Extract
collectExecutables from the help command and resolve symlinks via
os.Stat before checking executable bits. Broken symlinks are
silently skipped.
Also adds self-documenting help target to Makefile.
EARS: SYMLINK-001 through SYMLINK-006