Conversation
Changed the repository source for fetching LLVM sources in the workflow.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's GuideUpdates CI workflow conditions and repository references to target the 'zrsx' fork instead of the upstream 'llvm' organization, ensuring all guarded jobs and repo-specific operations run only on the forked repository. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- There are many repeated
ifconditions hardcodingzrsxorzrsx/llvm-project; consider centralizing these as reusable expressions (e.g., via a globalenvvariable or composite/reusable workflows) so changing the target owner/repo in the future is less error-prone. - The workflows mix
github.repository_owner == 'zrsx'andgithub.repository == 'zrsx/llvm-project'; it may be worth standardizing on one style where possible to make the triggering behavior easier to reason about and audit.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are many repeated `if` conditions hardcoding `zrsx` or `zrsx/llvm-project`; consider centralizing these as reusable expressions (e.g., via a global `env` variable or composite/reusable workflows) so changing the target owner/repo in the future is less error-prone.
- The workflows mix `github.repository_owner == 'zrsx'` and `github.repository == 'zrsx/llvm-project'`; it may be worth standardizing on one style where possible to make the triggering behavior easier to reason about and audit.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/bazel-checks.yml:
- Line 22: The workflow still contains a mismatched repository condition: update
the remaining conditional that uses "github.repository == 'llvm/llvm-project'"
to the new owner "github.repository == 'zrsx/llvm-project'" so the bazel-build
job runs for the migrated repo; search for the string "github.repository ==
'llvm/llvm-project'" in .github/workflows/bazel-checks.yml and replace it with
"github.repository == 'zrsx/llvm-project'" (the other condition already uses
"github.repository == 'zrsx/llvm-project'").
In @.github/workflows/libcxx-build-containers.yml:
- Line 28: The workflow gate was changed to github.repository_owner == 'zrsx'
but image references still point to ghcr.io/llvm/... which will fail to push
using secrets.GITHUB_TOKEN from the fork; update the image registry references
(the ghcr.io/llvm/... usages) to use the dynamic owner (e.g. ghcr.io/${{
github.repository_owner }}/...) or otherwise derive the namespace from
github.repository_owner, and ensure publish/save steps that use
secrets.GITHUB_TOKEN or a PAT are wired to the correct repo/owner; look for and
update the image names used in the publish/save steps to match the owner gate
and confirm the token/permission source used for pushing images.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b26a5993-a4e8-4555-ac1b-454ead55f5cf
📒 Files selected for processing (32)
.github/workflows/bazel-checks.yml.github/workflows/build-ci-container-tooling.yml.github/workflows/build-metrics-container.yml.github/workflows/check-ci.yml.github/workflows/ci-post-commit-analyzer.yml.github/workflows/commit-access-greeter.yml.github/workflows/commit-access-review.yml.github/workflows/docs.yml.github/workflows/email-check.yaml.github/workflows/issue-release-workflow.yml.github/workflows/issue-subscriber.yml.github/workflows/libclang-abi-tests.yml.github/workflows/libclang-python-tests.yml.github/workflows/libcxx-build-containers.yml.github/workflows/llvm-abi-tests.yml.github/workflows/llvm-bugs.yml.github/workflows/merged-prs.yml.github/workflows/mlir-spirv-tests.yml.github/workflows/new-issues.yml.github/workflows/new-prs.yml.github/workflows/pr-code-format.yml.github/workflows/pr-code-lint.yml.github/workflows/pr-subscriber.yml.github/workflows/premerge.yaml.github/workflows/release-asset-audit.yml.github/workflows/release-binaries.yml.github/workflows/release-sources.yml.github/workflows/release-tasks.yml.github/workflows/scorecard.yml.github/workflows/spirv-tests.yml.github/workflows/test-unprivileged-download-artifact.yml.github/workflows/version-check.yml
| name: "Buildifier" | ||
| runs-on: ubuntu-24.04 | ||
| if: github.repository == 'llvm/llvm-project' | ||
| if: github.repository == 'zrsx/llvm-project' |
There was a problem hiding this comment.
Incomplete owner migration leaves Bazel build/test disabled for the target repo.
Line 41 still uses github.repository == 'llvm/llvm-project', so bazel-build won’t run in zrsx/llvm-project even though Line 22 was migrated. This breaks CI coverage for the main Bazel validation path.
Suggested fix
- if: github.repository == 'llvm/llvm-project'
+ if: github.repository == 'zrsx/llvm-project'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/bazel-checks.yml at line 22, The workflow still contains a
mismatched repository condition: update the remaining conditional that uses
"github.repository == 'llvm/llvm-project'" to the new owner "github.repository
== 'zrsx/llvm-project'" so the bazel-build job runs for the migrated repo;
search for the string "github.repository == 'llvm/llvm-project'" in
.github/workflows/bazel-checks.yml and replace it with "github.repository ==
'zrsx/llvm-project'" (the other condition already uses "github.repository ==
'zrsx/llvm-project'").
| build-and-push: | ||
| runs-on: ubuntu-24.04 | ||
| if: github.repository_owner == 'llvm' | ||
| if: github.repository_owner == 'zrsx' |
There was a problem hiding this comment.
Registry namespace is now inconsistent with the new owner gate.
With Line 28 switched to zrsx, this workflow runs in the fork, but image references at Lines 75-77 still use ghcr.io/llvm/.... Using secrets.GITHUB_TOKEN from zrsx/llvm-project is unlikely to have push rights there, so publish/save steps can fail.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/libcxx-build-containers.yml at line 28, The workflow gate
was changed to github.repository_owner == 'zrsx' but image references still
point to ghcr.io/llvm/... which will fail to push using secrets.GITHUB_TOKEN
from the fork; update the image registry references (the ghcr.io/llvm/...
usages) to use the dynamic owner (e.g. ghcr.io/${{ github.repository_owner
}}/...) or otherwise derive the namespace from github.repository_owner, and
ensure publish/save steps that use secrets.GITHUB_TOKEN or a PAT are wired to
the correct repo/owner; look for and update the image names used in the
publish/save steps to match the owner gate and confirm the token/permission
source used for pushing images.
|
@coderabbitai Verify each finding against current code. Fix only still-valid issues, skip the In @.github/workflows/libcxx-build-containers.yml at line 28, The workflow gate |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
cat .github/workflows/libcxx-build-containers.ymlLength of output: 3355 🏁 Script executed: #!/bin/bash
cat libcxx/utils/ci/docker/docker-compose.yml 2>/dev/null || echo "FILE NOT FOUND"
# Also search broadly for any ghcr.io/llvm references in the workflow
rg "ghcr\.io/llvm" .github/workflows/libcxx-build-containers.yml -nLength of output: 2043 The finding is fully valid. Two locations are broken:
The
Failed to handle agent chat message. Please try again. |
Configure Dependabot for GitHub Actions updates with daily schedule and specific settings.
Removed remote cache and Google credentials from Bazel test command.
3 participants
Summary by Sourcery
Update GitHub Actions workflows to target the forked zrsx/llvm-project repository instead of the upstream llvm/llvm-project, including owner checks and repository references.
CI:
ifconditions to run only when the repository owner iszrsxor the repository iszrsx/llvm-projectacross all CI pipelines.zrsx/llvm-projectinstead ofllvm/llvm-projectwhere applicable.Summary by CodeRabbit
llvmtozrsxand fromllvm/llvm-projecttozrsx/llvm-project.