fix: pin @zuke/core ^1.25.0 across wrappers so fromNodeModules resolves#213
Merged
Conversation
Every tool wrapper inherits fromNodeModules from core's ToolSettings, added in core 1.25.0. Six wrappers were still published against an older core range that excludes 1.x, so calling the method at runtime failed with "s.fromNodeModules is not a function". PR #93 tightened the local dep to ^1 but landed as a chore, so those versions were never re-released and JSR keeps serving the old dependency. Bumping the floor to ^1.25.0 gives release-please a fix to cut for every core-dependent package, republishing them with a range that guarantees the method exists.
Contributor
|
🤖 Zuke AI review 🔎 security review —
|
Contributor
|
🤖 Zuke AI review 🔎 generic review —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.fromNodeModules()fails at runtime (s.fromNodeModules is not a function) on six published wrappers — oxlint, dprint, cspell, vitest, dpdm, vite.Verified against JSR: those six are published with
@zuke/core@^0(excludes 1.x), while tsc/nest/npm ship@zuke/core@^1. The method lives on core'sToolSettingsand landed in core 1.25.0, so a wrapper resolving pre-1.x core simply doesn't have it.Root cause
PR #93 tightened the local dep to
^1, but as achore:commit — release-please never bumped those package versions, so JSR keeps serving the old^0range under the current version (JSR versions are immutable).Fix
Bump the core dependency floor to
^1.25.0for all 53 core-dependent packages. This:fromNodeModules(and every otherToolSettingschainer) exists at runtime, even under a consumer lockfile /minimumDependencyAgethat would otherwise resolve pre-1.25 core;fix:to attribute to every package, re-releasing them with a correct range.Consumers importing wrappers at
@^0will pick up the patched versions automatically once released.Verification
deno task cigreen: check, test, coverage (98.3% lines / 95.2% branches) all pass.