Fix test case && issue of exceeding selectors#74
Open
khiav223577 wants to merge 8 commits intozweilove:masterfrom
Open
Fix test case && issue of exceeding selectors#74khiav223577 wants to merge 8 commits intozweilove:masterfrom
khiav223577 wants to merge 8 commits intozweilove:masterfrom
Conversation
Contributor
|
Hi reoy, thanks for your PR. I meant to take a look at it, but didn't find the time. Maybe it makes sense to ping the author(s) of the code you changed to answer your questions? Concerning the issue with the tests, can you maybe elaborate what the issue is and what you already tried? I think that could increase the change of somebody being able to help. |
Author
|
What I want to change mainly is this line: https://github.com/zweilove/css_splitter/pull/74/files#diff-3b8e9eb6bd155a54d793812eccd2b02cL15 "@media (min-width 768px){.a{}}".scan(/[^}]*}/).to_a
# => ["@media (min-width 768px){.a{}", "}"] `The author of the code is you. (6be6a2b#diff-3b8e9eb6bd155a54d793812eccd2b02cR15) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm trying to fix #72 (comment) and #71
I modify some test cases for the 1st issue and add a regression test case for the 2nd.
I try hard to make sure this PR pass all the tests, but have trouble with some of them ( #72 (comment) ). Could you help me?