Rename workflow and add WP-CLI ingestion to the workflow#46
Open
dbeja wants to merge 4 commits into
Open
Conversation
heiglandreas
left a comment
Collaborator
There was a problem hiding this comment.
Do we really need to do the commit with the result of the cmd-dump?
Can't we improve that by adding it to the worker-cache or - perhaps easier - by adding the wp cli cmd-dump > ${{ github.workspace }}/cli/data/wpcli-commands.json to the cd cli && composer install && ./bin/docsdangit ingest -s wp-cli so that the whole commandline would read something like this:
wp cli cmd-dump > ${{ github.workspace }}/cli/data/wpcli-commands.json && cd cli && composer install && ./bin/docsdangit ingest -s wp-cli`Or am I thinking too easy?
Collaborator
Author
|
@heiglandreas I agree with you, there's no need for the commit now that we do everything from the GitHub Action. I've removed the commit and also added 2 new params to the cli tool so we can define where to parse the dump file and the wp cli version and this way I'm using a temporary directory of the worker for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
.ymlextension to the WP-Cli workflow so it becomes active and implements the ingestion of the WP-Cli commands fetched into the database.This way, every day at 6am after fetching the full list of WP-CLI commands, they are automatically sent to the database, so the database has the latest version of them.
Closes #31.