fix(tui): add spacing after tree marker in tool details (merge conflicts resolved)#423
Merged
Nomikfk1215 merged 3 commits intomainfrom May 9, 2026
Merged
fix(tui): add spacing after tree marker in tool details (merge conflicts resolved)#423Nomikfk1215 merged 3 commits intomainfrom
Nomikfk1215 merged 3 commits intomainfrom
Conversation
fix(tui): add spacing after tree marker in tool details - Resolve merge conflicts with main branch - Update renderLiveInspectGroup test to match new function signature - Keep maxSubAgentToolsCollapsed constant from main Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
| } | ||
|
|
||
| view := stripANSI(renderLiveInspectGroup(group, 100, true, model{})) | ||
| if !strings.Contains(view, `└ "finalizeAssistantTurnForTool"`) { |
There was a problem hiding this comment.
Low: this only asserts that the spaced form appears somewhere in the rendered output. If a regression ever rendered both └"... and └ "... in the same view, this test would still pass. Asserting on the exact detail line, or also rejecting the unspaced variant, would make the regression coverage tighter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main└→└) for improved readability in tool detailsrenderLiveInspectGroupfunction signature (addedmodelparameter)maxSubAgentToolsCollapsedconstant from mainChanges
tui/component_conversation.go— mergedtoolTreeLeadconstant and detail rendering changes with main'srenderDiffDetailLinerefactoringtui/component_render_test.go— updatedTestRenderLiveInspectGroupDetailPrefixHasSpaceto passmodel{}argumentTest plan
go test ./tui/...passes🤖 Generated with Claude Code