Skip to content

fix(tui): add spacing after tree marker in tool details (merge conflicts resolved) #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nomikfk1215 merged 3 commits into from
May 9, 2026
Merged

fix(tui): add spacing after tree marker in tool details (merge conflicts resolved) #423

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f37bd6
fix(tui): add spacing after tree marker in tool details
mickey-228 May 8, 2026
1a0cb04
test(tui): cover spaced tree prefix in live inspect details
mickey-228 May 8, 2026
738c147
Merge pull request #407 from 1024XEngineer/codex/tool-tree-spacing
Nomikfk1215 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tui/component_render_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,17 @@ func TestRenderBytemindRunCardCollapsedLiveInspectSummaryAcrossTools(t *testing.
}
}

func TestRenderLiveInspectGroupDetailPrefixHasSpace(t *testing.T) {
group := []chatEntry{
{Kind: "tool", Title: toolEntryTitle("search_text"), Status: "running", CompactBody: `"finalizeAssistantTurnForTool"`},
}

view := stripANSI(renderLiveInspectGroup(group, 100, true, model{}))
if !strings.Contains(view, `└ "finalizeAssistantTurnForTool"`) {
Copy link
Copy Markdown

@fennoai fennoai Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: this only asserts that the spaced form appears somewhere in the rendered output. If a regression ever rendered both └"... and └ "... in the same view, this test would still pass. Asserting on the exact detail line, or also rejecting the unspaced variant, would make the regression coverage tighter.

t.Fatalf("expected live inspect detail prefix to include a space after tree marker, got %q", view)
}
}

func TestRenderBytemindRunCardCollapsedDoneInspectGroupKeepsSingleLine(t *testing.T) {
entries := []chatEntry{
{Kind: "tool", Title: toolEntryTitle("search_text"), Status: "done", CompactBody: `17 matches for "toolDetailsExpanded"`},
Expand Down
Loading