fix(test): correct dead test functions for get_u/get_v in test_weather.py

[pankaj-bind]

Related Issue / Discussion:

Fixes Issue #161

Changes:

• Modified test_weather.py

Further Details:

Summary:

get_u() and get_v() in test_weather.py had 5 compounding defects that made them dead code:

1. Missing test_ prefix - pytest never collected them
2. @parametrize declared 3 params but signatures accepted 2
3. Assertions compared results to themselves (u_test == pytest.approx(u_test))
4. Expected values were wrong (-1 instead of -√2/2 for sin(45°))
5. get_v's parametrize string said u_res instead of v_res

Before: 4 tests collected, get_u/get_v never executed.
After: 39 tests collected, all passing. Added cardinal-direction cases (0°, 90°, 180°, 270°) with textbook-exact values, magnitude invariant tests (√(u²+v²) = |windspeed|), and round-trip consistency tests (get_theta_from_uv(get_u(θ), get_v(θ)) == θ).

No production code changed.

Dependencies:

None

PR Checklist:

In the context of this PR, I:

• have (already previously) filled the 52North Contributor License Agreement and received positive feedback on this matter
• have filled the 52North Contributor License Agreement and am waiting for feedback
• provide unit tests embedded in the WRT test framework (WeatherRoutingTool/tests) that allow the simple testing of the new/modified functionalities. All (previous and new) unit tests execute without new error messages.
• ensure that the code formatter runs without errors/warnings
• ensure that my changes follow the WRT’s guidelines for contributing at the time of the contribution

Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.

@MartinPontius @kdemmich

[Copilot]

Pull request overview

This PR fixes and expands unit tests in tests/test_weather.py so that WeatherCond.get_u() / get_v() are actually collected by pytest and correctly validate the degree-based wind-direction math used by WeatherCond.

Changes:

• Renamed previously “dead” test functions to be pytest-collectable and corrected parameterization/signatures and assertions.
• Corrected expected values for key angles (including 45° cases) and added cardinal-direction test cases.
• Added additional invariants: vector magnitude equals |windspeed| and u/v → theta round-trip consistency.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.