Skip to content

fix(test): correct dead test functions for get_u/get_v in test_weather.py #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pankaj-bind wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(test): correct dead test functions for get_u/get_v in test_weather.py #160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f91f8
fix: correct dead test functions for get_u/get_v in test_weather.py
pankaj-bind Mar 7, 2026
4b2cf60
Refactor parameterized tests for weather functions
pankaj-bind Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 52 additions & 6 deletions tests/test_weather.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import math

import pytest

from WeatherRoutingTool.weather import WeatherCond

SQRT2_2 = math.sqrt(2) / 2


@pytest.mark.parametrize("u,v,theta_res", [(-1, -1, 45), (1, -1, 315), (1, 1, 225), (-1, 1, 135)])
def test_theta_from_uv(u, v, theta_res):
Expand All @@ -10,15 +14,57 @@ def test_theta_from_uv(u, v, theta_res):
assert theta_test == pytest.approx(theta_res)


@pytest.mark.parametrize("theta,windspeed,u_res", [(45, 1, -1), (315, 1, 1), (225, 1, 1), (135, 1, -1)])
def get_u(theta, windspeed):
@pytest.mark.parametrize("theta,windspeed,u_res", [
(0, 1, 0.0),
(90, 1, -1.0),
(180, 1, 0.0),
(270, 1, 1.0),
(45, 1, -SQRT2_2),
(135, 1, -SQRT2_2),
(225, 1, SQRT2_2),
(315, 1, SQRT2_2),
])
def test_get_u(theta, windspeed, u_res):
u_test = WeatherCond.get_u(theta, windspeed)

assert u_test == pytest.approx(u_test)
assert u_test == pytest.approx(u_res)


@pytest.mark.parametrize("theta,windspeed,u_res", [(45, 1, -1), (315, 1, -1), (225, 1, 1), (135, 1, 1)])
def get_v(theta, windspeed):
@pytest.mark.parametrize("theta,windspeed,v_res", [
(0, 1, -1.0),
(90, 1, 0.0),
(180, 1, 1.0),
(270, 1, 0.0),
(45, 1, -SQRT2_2),
(135, 1, SQRT2_2),
(225, 1, SQRT2_2),
(315, 1, -SQRT2_2),
])
def test_get_v(theta, windspeed, v_res):
v_test = WeatherCond.get_v(theta, windspeed)

assert v_test == pytest.approx(v_test)
assert v_test == pytest.approx(v_res)


@pytest.mark.parametrize("theta,windspeed", [
(0, 1), (45, 1), (90, 1), (135, 1),
(180, 1), (225, 1), (270, 1), (315, 1),
(60, 5), (120, 0.5),
])
def test_uv_magnitude_equals_windspeed(theta, windspeed):
u = WeatherCond.get_u(theta, windspeed)
v = WeatherCond.get_v(theta, windspeed)

assert math.sqrt(u**2 + v**2) == pytest.approx(abs(windspeed))


@pytest.mark.parametrize("theta,windspeed", [
(0, 1), (45, 1), (90, 1), (135, 1),
(180, 1), (225, 1), (270, 1), (315, 1),
(60, 3),
])
def test_uv_roundtrip_recovers_theta(theta, windspeed):
u = WeatherCond.get_u(theta, windspeed)
v = WeatherCond.get_v(theta, windspeed)

assert WeatherCond.get_theta_from_uv(u, v) == pytest.approx(theta)
Loading