acmego: allow arbitrary rc filters enclosed in [[ ]]#111
Closed
jacobvosmaer wants to merge 2 commits into9fans:mainfrom
Closed
acmego: allow arbitrary rc filters enclosed in [[ ]]#111jacobvosmaer wants to merge 2 commits into9fans:mainfrom
jacobvosmaer wants to merge 2 commits into9fans:mainfrom
Conversation
jacobvosmaer
commented
Nov 10, 2023
6b7df6b to
1697ab5
Compare
Author
|
There was an issue where we could only read the first line of the tag, because of looking it up via I also fixed a usability quirk: the first iteration required an explicit |
1697ab5 to
31d38fc
Compare
Author
|
OK so I learned that having the filter read from stdin is not practical: it prevents |
Author
|
Closing in favor of #112. That one is much nicer to work with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to automatically run
clang-formaton some but not all C files I edit. Not every project uses it and I don't want to mess up an entire file while making a one-line change.This commit adds a new
[[filter]]syntax for the tag. In my case I would write[[clang-format]]into the tag of my C file and then when I hit Put, acmego runsrc -c 'clang-format $1' /path/to/file.c.To avoid conflicts with Edit, we ignore
[[if it occurs after Edit.I don't know if this commit is the ideal design but I think acmego ought to be able to do something like this. It would elevate it to the same level of flexibility as Watch.