Use clang-format for .c and .h files#112
Open
jacobvosmaer wants to merge 2 commits into9fans:mainfrom
Open
Conversation
jacobvosmaer
commented
Jan 16, 2024
| // The other known extensions and formatters are: | ||
| // | ||
| // .rs - rustfmt | ||
| // |
Author
There was a problem hiding this comment.
This line got deleted, ironically, by acmego. I need to add a comment about .c and .h here.
jacobvosmaer
commented
Jan 16, 2024
| ".go": []string{"goimports"}, | ||
| type formatter struct { | ||
| cmd []string | ||
| enabled func(string) bool |
Author
There was a problem hiding this comment.
I suppose we could have a method Enabled() which returns true if this callback field is nil.
Because clang-format is not used universally, this change adds a check so that we only run clang-format if a .clang-format file can be found higher up in the directory tree.
jacobvosmaer
force-pushed
the
jv-clang-format
branch
from
2542f3b to
e2df5eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because clang-format is not used universally, this change adds a check so that we only run clang-format if a .clang-format file can be found higher up in the directory tree.
This is an alternative approach to #111. I find it gets tedious to define a filter for each file I open.