Install Docker Python packages in an isolated venv#1001
Open
dicnunz wants to merge 1 commit into
Open
Conversation
Author
|
Small paid-fix note: if this closes the Docker Python packaging issue and saves maintainer time, I am asking $10 here: https://nicdunz.gumroad.com/l/slop-kill-pass?wanted=true No issue if this repo only handles volunteer contributions; the PR is intended to stand on its own. |
191337d to
b272c88
Compare
Author
|
Rebased this onto current The PR diff is still limited to the Dockerfile Python package install path:
Validation after rebase:
I did not rerun a full Docker build locally because that is heavier than this branch-only refresh, but the rebased diff is unchanged in scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/opt/training-modules-pythoninstead of the system interpreterVIRTUAL_ENVandPATHfor all later Dockerfile steps and container userspython3-venvso the image can create the environment without--break-system-packagesCloses #885.
Verification
git diff --checkdocker buildx build --check .python3 -m venv /tmp/training-modules-venv-check && /tmp/training-modules-venv-check/bin/python -m pip --version && rm -rf /tmp/training-modules-venv-checkNote: I did not run a full Docker build locally because this image compiles/downloads the full workshop stack. The Dockerfile static build check passes and covers Dockerfile parsing/build checks.