fix: dataprocess validator allow name or notes to specify Other#1837
Merged
Conversation
tmchartrand
force-pushed
the
fix-dataprocess-validator
branch
from
470fbc8 to
4a5185c
Compare
dbirman
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DataProcess validator required specifying additional details if process_type took the generic value 'Other', in the notes field - this was a relic of v1 because name was a controlled field, while now name is separate from process_type, so specifying the details of generic processes in the name should be preferred. Providing details in notes is still allowed for backwards compatibility.
This also adds the same behavior for process_type 'Analysis' which is also intended as a generic type - this is technically breaking, but the only records that use that type currently were created by the upgrader, and they have details in notes already.