Skip to content

Snr + Kurtosis from nwb#87

Closed
rachelstephlee wants to merge 8 commits into
mainfrom
kurtosis_from_nwb
Closed

Snr + Kurtosis from nwb#87
rachelstephlee wants to merge 8 commits into
mainfrom
kurtosis_from_nwb

Conversation

@rachelstephlee

Copy link
Copy Markdown
Collaborator

calculating snr and kurtosis from nwbs

@hagikent hagikent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@alexpiet

alexpiet commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

I'm fine with putting this here for now, since there is other FIP related functions in this repo. But, we should probably refactor all FIP functions to a separate "AIND-FIP-UTILS repo" so that its easy to use for pavolvian, and VR-foraging data.

@rachelstephlee

rachelstephlee commented Nov 11, 2025

Copy link
Copy Markdown
Collaborator Author

yes, all that sounds reasonable. somehow i'm failing tests (it's not linting) which is why this PR also fell to the wayside.

i'll see if i can sort it out then i assume i can merge as long as the tests pass?

TODO for rachel:

  • fix the test fails.
  • change the names of the functions back-- have your function be a different name so when we refactor, it will cause less disruptions.
  • check with alex again before merging in PR

@rachelstephlee

Copy link
Copy Markdown
Collaborator Author

closing this because the original works better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants