fix: render tool summary header and content as one container#494
Draft
laileni-aws wants to merge 2 commits into
Draft
fix: render tool summary header and content as one container#494laileni-aws wants to merge 2 commits into
laileni-aws wants to merge 2 commits into
Conversation
When a tool summary (e.g. an MCP tool call) is expanded, the header and the collapsed content were shown as separate rounded boxes. Square the header's bottom corners and give the expanded content matching side and bottom borders (with the header's bottom border acting as the divider), and clip the inner cards to the container shape, so the summary reads as a single container with a divider between the header and the parameters/results.
Keeps the repo lint gate green (strict-boolean-expressions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a tool summary (for example an MCP tool call) is expanded in chat, the header (" ✓ Completed") and the expanded content ("Parameters" and results) render as separate rounded boxes. Per the UX spec they should read as a single container — the bottom of the header and the top of the content should not be rounded, with a divider between the header and the content.
Fix
In
src/styles/components/chat/_chat-item-card.scss, when the summary is expanded (.show-summary):border-bottom-*-radius: 0).overflow: hiddenso the inner parameter/result cards are clipped to the container shape.The result is a single bordered container: header on top, a divider, then the parameters/results, with only the outer corners rounded.
Scope / testing
.mynah-chat-item-card-summarystyles (the tool-summary component); no other components are affected.npm run buildcompiles the styles successfully; full unit suite andeslint/prettierpass.Additional change
ui-tests/__test__/flows/quick-action-commands-header.ts: coerced a Playwrightevaluateresult to a boolean withBoolean(...)to satisfy@typescript-eslint/strict-boolean-expressionsand keep the repo lint gate green.