Skip to content

fix: render tool summary header and content as one container #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
laileni-aws wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −4
Draft

fix: render tool summary header and content as one container #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a1c528
fix: render tool summary header and content as one container
laileni-aws Jul 15, 2026
d7457b3
chore: coerce evaluate result to boolean in quick-action header flow
laileni-aws Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/styles/components/chat/_chat-item-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,27 @@
display: none;
flex-flow: column nowrap;
}
&.show-summary > .mynah-chat-item-card-summary-collapsed-content {
display: flex;
// When expanded, the header and the collapsed content should read as a
// single container instead of separate rounded boxes. Square the header's
// bottom corners and the content's top corners so they connect, and let the
// header's bottom border act as the divider between the header and the
// parameters/results below.
&.show-summary {
> .mynah-chat-item-card-summary-content {
border-bottom-left-radius: 0;
border-bottom-right-radius: 0;
}
> .mynah-chat-item-card-summary-collapsed-content {
display: flex;
border-right: var(--mynah-border-width) solid var(--mynah-color-border-default);
border-bottom: var(--mynah-border-width) solid var(--mynah-color-border-default);
border-left: var(--mynah-border-width) solid var(--mynah-color-border-default);
border-bottom-left-radius: var(--mynah-card-radius);
border-bottom-right-radius: var(--mynah-card-radius);
// Clip the inner parameter/result cards to the container's shape so
// their own corners do not create separate rounded boxes.
overflow: hidden;
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ui-tests/__test__/flows/quick-action-commands-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ export const verifyQuickActionCommandsHeaderStatusVariations = async (page: Page
let foundStatusClass = false;

for (const statusClass of statusClasses) {
const hasStatus = await headerElement.evaluate((el, className) =>
const hasStatus = Boolean(await headerElement.evaluate((el, className) =>
el.classList.contains(className), statusClass
);
));
if (hasStatus) {
foundStatusClass = true;
console.log(`Found status class: ${statusClass}`);
Expand Down
Loading