Open
Conversation
yashLadha
reviewed
Jul 9, 2020
| PluginLogger.log(logger,"Access key is not empty"); | ||
| } | ||
|
|
||
| if (binarypath != null && binarypath.length() > 0) { |
Owner
Author
There was a problem hiding this comment.
The objective of the PR is to add logging. The code check for existence should be part of the existing local binary code.
AmeyaJoshi1
pushed a commit
that referenced
this pull request
Jan 28, 2021
BrowserStack Report via pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have one reported customer reporting issue while starting browserstack local binary in daemon mode.
This issue is occurring at particular client setup only. This PR is to add debug lines for the mentioned issue