Skip to content

Detailed logs enabled for local #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AmeyaJoshi1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Detailed logs enabled for local #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a134e18
Added log lines for debugging purpose
AmeyaJoshi1 Jul 9, 2020
ffcf505
Updated log lines
AmeyaJoshi1 Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/main/java/com/browserstack/automate/ci/jenkins/local/JenkinsBrowserStackLocal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
import hudson.Launcher;
import jenkins.security.MasterToSlaveCallable;
import java.io.PrintStream;
import java.io.PrintWriter;
import org.apache.commons.lang.StringUtils;

import java.io.IOException;
import java.io.Serializable;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -80,10 +82,33 @@ private String[] processLocalArguments(final String argString, String buildTag)
}

public void start() throws Exception {
PluginLogger.log(logger,"Checking local options");
Map<String, String> localOptions = new HashMap<String, String>();
localOptions.put("key", accesskey);
if (binarypath != null && binarypath.length() > 0) localOptions.put("binarypath", binarypath);
super.start(localOptions);

if(accesskey == null || accesskey.length()==0) {
PluginLogger.log(logger,"Access key is empty");
}else {
PluginLogger.log(logger,"Access key is not empty");
}

if (binarypath != null && binarypath.length() > 0) {
Copy link
Copy Markdown

@yashLadha yashLadha Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be check for existence?

Copy link
Copy Markdown
Owner Author

@AmeyaJoshi1 AmeyaJoshi1 Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objective of the PR is to add logging. The code check for existence should be part of the existing local binary code.

localOptions.put("binarypath", binarypath);
PluginLogger.log(logger,"binarypath is "+binarypath);
}else {
PluginLogger.log(logger,"binarypath is not added");
}

PluginLogger.log(logger,"Starting local");
try {
super.start(localOptions);
} catch (Exception e) {
StringWriter sw = new StringWriter();
e.printStackTrace(new PrintWriter(sw));
String exceptionAsString = sw.toString();
PluginLogger.log(logger,"Actual Exception is\n" + exceptionAsString);
throw e;
}
}

public void stop() throws Exception {
Expand All @@ -94,10 +119,13 @@ public void stop() throws Exception {
}

public void start(Launcher launcher) throws Exception {
PluginLogger.log(logger,"will be fetching launcher channels and calling start");
launcher.getChannel().call(new MasterToSlaveCallable<Void, Exception>() {
@Override
public Void call() throws Exception {
PluginLogger.log(logger,"will call actual start method");
JenkinsBrowserStackLocal.this.start();
PluginLogger.log(logger,"start call completed");
return null;
}
});
Expand Down