Skip to content

feat: verbose build#248

Merged
ezavada merged 10 commits into
mainfrom
edz/verbose_build
Jul 11, 2025
Merged

feat: verbose build#248
ezavada merged 10 commits into
mainfrom
edz/verbose_build

Conversation

@ezavada

@ezavada ezavada commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

Overview

Description of the overall background and high-level changes that this PR introduces

Brief Changelog

Testing and Verifying

Greptile Summary

Adds verbose build mode to World CLI but introduces significant security and performance concerns in the Docker build process.

  • Security Risk: Removed secure GitHub token handling in cardinal.Dockerfile and exposed token debugging, potentially leaking sensitive credentials
  • Performance Impact: Disabled BuildKit by default and removed build cache mounting in cardinal.Dockerfile, significantly impacting build speed
  • Dependency Risk: Modified cardinal.Dockerfile to remove go.sum before go mod tidy, which could lead to inconsistent dependencies
  • Build Changes: Added verbose logging throughout Docker operations in client_image.go for better debugging capabilities
  • Error Handling: Replaced BuildKit requirement panic with warning in cardinal.go, though this may mask security implications

@graphite-app

graphite-app Bot commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

How to use the Graphite Merge Queue

Add the label graphite/merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov

codecov Bot commented Jul 11, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 1.81818% with 270 lines in your changes missing coverage. Please review.

Project coverage is 39.93%. Comparing base (804252c) to head (62c83c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/app/world-cli/common/docker/client_image.go 0.58% 168 Missing and 3 partials ⚠️
internal/app/world-cli/gen/logs/v1/logs.pb.go 0.00% 90 Missing ⚠️
...al/app/world-cli/common/docker/service/cardinal.go 0.00% 6 Missing ⚠️
internal/app/world-cli/common/telemetry/sentry.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   41.30%   39.93%   -1.37%     
==========================================
  Files          99      100       +1     
  Lines        6811     7046     +235     
==========================================
+ Hits         2813     2814       +1     
- Misses       3707     3938     +231     
- Partials      291      294       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ezavada ezavada marked this pull request as ready for review July 11, 2025 01:33

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 9 comments
Edit PR Review Bot Settings | Greptile

Comment thread internal/app/world-cli/common/telemetry/sentry.go
Comment thread internal/app/world-cli/common/docker/client_util.go
Comment thread internal/app/world-cli/common/docker/client_util.go
Comment thread cmd/world/main.go
Comment thread internal/app/world-cli/common/docker/service/cardinal.Dockerfile
Comment thread internal/app/world-cli/common/docker/service/cardinal.Dockerfile
Comment thread internal/app/world-cli/common/docker/service/cardinal.go
Comment thread internal/app/world-cli/common/docker/service/cardinal.Dockerfile
Comment thread internal/app/world-cli/common/docker/client_image.go

@AnthonyWadham AnthonyWadham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get how the verbose mode works I was always confused because it did nothing 😂

@ezavada ezavada merged commit d99b0b8 into main Jul 11, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants