feat: verbose build#248
Conversation
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 41.30% 39.93% -1.37%
==========================================
Files 99 100 +1
Lines 6811 7046 +235
==========================================
+ Hits 2813 2814 +1
- Misses 3707 3938 +231
- Partials 291 294 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
6 files reviewed, 9 comments
Edit PR Review Bot Settings | Greptile
AnthonyWadham
left a comment
There was a problem hiding this comment.
Now I get how the verbose mode works I was always confused because it did nothing 😂
Overview
Brief Changelog
Testing and Verifying
Greptile Summary
Adds verbose build mode to World CLI but introduces significant security and performance concerns in the Docker build process.
cardinal.Dockerfileand exposed token debugging, potentially leaking sensitive credentialscardinal.Dockerfile, significantly impacting build speedcardinal.Dockerfileto removego.sumbeforego mod tidy, which could lead to inconsistent dependenciesclient_image.gofor better debugging capabilitiescardinal.go, though this may mask security implications