Skip to content

feat: verbose build #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezavada merged 10 commits into from
Jul 11, 2025
Merged

feat: verbose build #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5b2e780
testing buildkite
Jul 10, 2025
9eab46d
buildkite session
Jul 10, 2025
ac9eb6c
remove buildkit
Jul 10, 2025
819401f
added verbose logging for build
Jul 10, 2025
1900c3f
wip on finding problems with GITHUB_TOKEN
Jul 10, 2025
1e694c6
fixed errors from rebase after Anthony's big reorg
Jul 11, 2025
b5a9ccb
actually report the GITHUB_TOKEN in the verbose logging
Jul 11, 2025
ea6634d
Updated error message for sentry dsn
Jul 11, 2025
eaeafc6
fixed a bunch of linter errors
Jul 11, 2025
62c83c2
add generated pb.go for go install
zulkhair Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/world/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,12 @@ func main() {
Summary: true,
}),
)

// Set verbose mode if the flag is enabled
if CLI.Verbose {
logger.VerboseMode = true
}
Comment thread
ezavada marked this conversation as resolved.

realCtx := contextWithSigterm(context.Background())
SetKongParentsAndContext(realCtx, dependencies, &CLI)
SetKongParentsAndContext(realCtx, dependencies, &CardinalCmdPlugin)
Expand Down
1 change: 0 additions & 1 deletion internal/app/world-cli/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ Thumbs.db
*.log

# Generated Go files (protobuf, codegen)
*.pb.go
*.pb.gw.go
*.gen.go

Expand Down
Loading
Loading