feat(float): upgrade SDK to 2.0.0, add pytest unit tests by Shubhank-Jonnada · Pull Request #284 · Autohive-AI/autohive-integrations

Shubhank-Jonnada · 2026-04-28T22:38:51Z

Summary

Upgrades Float integration to SDK 2.0.0
Fixes auth pattern: context.auth.get("credentials", {}).get("api_key", "")
All optional params use inputs.get(), required params use inputs["param"]
Uses response.data / response.status from FetchResponse
Returns ActionError(message=str(e)) on errors
Added complete test suite: 13 unit tests + 43 integration tests covering all 52 actions
Fixed config.json output schemas: nullable fields now accept null, active fields accept integer (Float API returns 1/0, not booleans)

Test Results

Unit Tests (mocked, CI-safe) — 13 passed ✅

test_list_people_returns_data         PASSED
test_list_people_with_filters         PASSED
test_get_person_required_param        PASSED
test_list_projects_returns_data       PASSED
test_list_tasks_no_params             PASSED
test_list_clients_no_params           PASSED
test_list_departments_no_params       PASSED
test_list_roles_no_params             PASSED
test_auth_headers_use_api_key         PASSED
test_delete_person_success            PASSED
test_create_person_required_name      PASSED
test_list_time_off_no_params          PASSED
test_list_logged_time_no_params       PASSED

13 passed in 0.23s

Integration Tests (live Float API — 2026-05-04) — 34 passed, 9 skipped ✅

TestListPeople::test_returns_list                     PASSED
TestListPeople::test_limit_respected                  PASSED
TestGetPerson::test_returns_person                    PASSED
TestListProjects::test_returns_list                   PASSED
TestListProjects::test_limit_respected                PASSED
TestGetProject::test_returns_project                  PASSED
TestListTasks::test_returns_list                      PASSED
TestGetTask::test_returns_task                        SKIPPED (no tasks in account)
TestListClients::test_returns_list                    PASSED
TestGetClient::test_returns_client                    SKIPPED (no clients)
TestListTimeOff::test_returns_list                    PASSED
TestListLoggedTime::test_returns_list                 PASSED
TestListDepartments::test_returns_list                PASSED
TestGetDepartment::test_returns_department            PASSED
TestListRoles::test_returns_list                      PASSED
TestGetRole::test_returns_role                        SKIPPED (no roles)
TestListTimeOffTypes::test_returns_list               PASSED
TestGetTimeOffType::test_returns_time_off_type        PASSED
TestListAccounts::test_returns_list                   PASSED
TestGetAccount::test_returns_account                  PASSED
TestListStatuses::test_returns_list                   PASSED
TestGetStatus::test_returns_status                    SKIPPED (no statuses)
TestListPublicHolidays::test_returns_list             PASSED
TestGetPublicHoliday::test_returns_holiday            PASSED
TestListTeamHolidays::test_returns_list               PASSED
TestGetTeamHoliday::test_returns_holiday              SKIPPED (no team holidays)
TestListProjectStages::test_returns_list              PASSED
TestGetProjectStage::test_returns_stage               PASSED
TestListProjectExpenses::test_returns_list            PASSED
TestGetProjectExpense::test_returns_expense           SKIPPED (no expenses)
TestListPhases::test_returns_list                     PASSED
TestGetPhase::test_returns_phase                      SKIPPED (no phases)
TestListProjectTasks::test_returns_list               PASSED
TestGetProjectTask::test_returns_task                 PASSED
TestListMilestones::test_returns_list                 PASSED
TestGetMilestone::test_returns_milestone              SKIPPED (no milestones)
TestReports::test_get_people_report                   PASSED
TestReports::test_get_projects_report                 PASSED
TestClientLifecycle::test_full_lifecycle              PASSED
TestPersonLifecycle::test_full_lifecycle              PASSED
TestProjectLifecycle::test_full_lifecycle             PASSED
TestTaskLifecycle::test_full_lifecycle                PASSED
TestMergeProjectTasks::test_merge_project_tasks       PASSED

34 passed, 9 skipped in 25.96s

Skipped tests are due to empty test account (no existing clients, roles, statuses, etc.) — not integration failures.

Validation

validate_integration.py: 0 errors, 0 warnings ✅
check_code.py: PASSED ✅

- Bump autohive-integrations-sdk pin from ==1.0.2 to ~=2.0.0 - Update all context.fetch() call sites to access .data on FetchResponse - Fix connected account handler to use response.data for isinstance check - Bump config.json version to 2.0.0 - Create float/tests/conftest.py with standard sys.path insert - Create float/tests/test_float_unit.py with 71 unit tests covering people, projects, tasks, time off, logged time, clients, departments, roles, reference data, holidays, phases, milestones, reports, and auth header verification

github-actions · 2026-04-28T22:39:30Z

🔍 Integration Validation Results

Commit: ca1b05779bdf8c3846dc2cfa7dd7c9f6dd8bf5ff · style(float): apply ruff formatting to test_float_integration.py
Updated: 2026-05-04T04:41:28Z

Changed directories: float

Check	Result
Structure	✅ Passed
Code	✅ Passed
Tests	✅ Passed
README	✅ Passed
Version	✅ Passed

✅ Structure Check output

Validating 1 integration(s)...

============================================================
Integration: float
============================================================
✅ All checks passed!

============================================================
SUMMARY
============================================================
Integrations validated: 1
Total errors: 0
Total warnings: 0

✅ All validations passed!

✅ Code Check output


[notice] A new release of pip is available: 26.0.1 -> 26.1
[notice] To update, run: pip install --upgrade pip
----------------------------------------
Checking: float
----------------------------------------

📦 Installing dependencies...

🐍 Checking Python syntax...
   ✅ Syntax OK

📥 Checking imports...
   ✅ Imports OK

📄 Checking JSON files...
   ✅ JSON files OK

🔍 Linting with ruff...
   ✅ Lint OK

🎨 Checking formatting with ruff...
   ✅ Formatting OK

🔒 Scanning for security issues with bandit...
   ✅ Security OK

🛡️ Checking dependencies for vulnerabilities with pip-audit...
   ✅ Dependencies OK

🔗 Checking config-code sync...
   ✅ Config-code sync OK

🔄 Checking fetch patterns...
   ✅ Fetch patterns OK

========================================
✅ CODE CHECK PASSED
========================================

✅ Tests Check output


Integration   Tests  Coverage        Status
-------------------------------------------
float   119/119       72%      ✅ Passed
-------------------------------------------
Total   119/119            ✅ All passed

✅ Tests passed: float

✅ README Check output

========================================
✅ README CHECK PASSED
========================================

✅ Version Check output

✅ float: 1.0.0 → 2.0.0 (major bump)

========================================
✅ VERSION CHECK PASSED
========================================

…pe assertions - Add ActionError import and convert all raise Exception() error paths to return ActionError(message=...) - Fix action handlers to use response.data from FetchResponse - Fix connected account handler to use response.data - Replace integration-style test_float.py with proper unit tests split by domain - 106 unit tests across 5 files: people, projects, tasks, timeoff, misc - All tests use FetchResponse mocks and ResultType.ACTION_ERROR assertions per skill

…tead of pytest.raises

TheRealAgentK

SDK 2.0.0 migration looks clean and 71 new unit tests run alongside the existing suite (177 total). Local CI verified: validate_integration ✅, check_code ✅, ruff ✅, pytest ✅.

Blocking on one thing: no tests/test_float_integration.py. float uses a custom API-key auth, so adding e2e coverage is low-cost — one env var (FLOAT_API_KEY) and the live_context fixture per the writing-integration-tests skill. Please add at minimum read-only smoke coverage for the major resource families (people, projects, tasks, allocations) before merge. Mark any create/update/delete tests with @pytest.mark.destructive.

Also: branch name doesn't follow <type>/<issue#>/<desc> per AGENTS.md, and no linked issue.

…n tests

…ion tests passing

TheRealAgentK

🔴 Must fix — `os.chdir(_parent)` is process-global

Three places at module level:

os.chdir() changes the cwd for the whole pytest process. pytest . collects these files and the cwd leaks into every other integration's tests, breaking anything that uses relative paths. The other 4 unit-test files in this PR don't do it. The importlib.spec_from_file_location block uses an absolute path, so the chdir isn't needed — remove all three.

🟡 Files to clean up

float/tests/conftest.py — slim it down. The importlib.spec_from_file_location block is redundant: every test file independently loads float_mod again. Renaming the conftest out and re-running the suite produces the same 119/119 pass result. Drop the importlib block (and the chdir that comes with it). The validator requires either conftest.py or context.py, so the file should stay — minimum content satisfies the rule.
float/tests/test_float.py — pre-upgrade asyncio.run testbed. Not just unused: actually broken. from context import float raises ImportError: cannot import name 'float' from 'context' because context.py doesn't re-export anything. Same shape as test_supadata_transcribe.py deleted in #280.
float/tests/context.py — only referenced by the broken test_float.py. Goes with it.

…ontext.py

…tions - Make all output schema field types nullable to match Float API reality (API returns null for many optional fields that were typed as non-nullable) - Change `active` field type from boolean to [integer, boolean, null] since Float API returns 1/0 integers, not booleans - Fix list_statuses to return [] instead of None on 204 No Content response - Fix integration test assertions: - List endpoints: assert isinstance(data, list) not wrapped key access - Get endpoints: assert isinstance(data, dict) not wrapped key access - Use task_meta_id fallback for project_task items (API uses different key) - Use id fallback for public_holiday and project_stage items - Destructive tests: access fields directly on dict not via nested wrapper

Shubhank-Jonnada · 2026-05-04T04:30:28Z

@TheRealAgentK — addressed all reviewer feedback and ran full live tests against the Float API.

Changes made:

Removed all os.chdir() calls (were process-global, leaked into other tests)
Deleted legacy test_float.py and context.py (broken files, not needed)
Expanded integration tests from 5 → 43 tests covering all 52 actions
Fixed config.json output schemas: all fields now allow null (Float API returns many nullable fields), active accepts integers (Float returns 1/0, not booleans)
Fixed list_statuses to return [] on HTTP 204 No Content

Live test results: 34 passed, 9 skipped (skips are empty-account data gaps, not failures)

Full results

34 passed, 9 skipped in 25.96s

Passed: list/get for people, projects, tasks, departments, accounts, time-off types,
        public holidays, project stages, project tasks, milestones, reports, 
        + full create→update→delete lifecycle for clients, people, projects, tasks, merge
Skipped: get tests for clients/roles/statuses/team holidays/expenses/phases/milestones
         (test account has no data for these resources)

TheRealAgentK

LGTM now

Shubhank-Jonnada added the Ready label Apr 28, 2026

fix(float): fix 3 error path tests to use ResultType.ACTION_ERROR ins…

2164bd9

…tead of pytest.raises

TheRealAgentK mentioned this pull request Apr 29, 2026

feat(teams): Microsoft Teams integration via Graph API #292

Closed

4 tasks

TheRealAgentK requested changes Apr 29, 2026

View reviewed changes

Shubhank-Jonnada added 4 commits May 1, 2026 14:52

fix(float): fix auth, optional params, add proper unit and integratio…

d8510e4

…n tests

fix(float): bump SDK to 2.0.0, format tests, verify 5/5 live integrat…

fc20fd5

…ion tests passing

fix(float): bump version to 2.0.0, fix isinstance to use response.data

76caa5e

style(float): apply ruff formatting

d6324b6

Shubhank-Jonnada requested a review from TheRealAgentK May 1, 2026 03:48

Merge branch 'master' into fix/float-sdk-upgrade-v2

a7e1f16

TheRealAgentK requested changes May 4, 2026

View reviewed changes

Shubhank-Jonnada added 3 commits May 4, 2026 16:16

fix(float): remove os.chdir, delete broken legacy test_float.py and c…

cc1ebab

…ontext.py

test(float): expand integration tests to cover all 52 actions

c443712

TheRealAgentK mentioned this pull request May 4, 2026

fix(humanitix): upgrade SDK to v2.0.0, add unit and integration tests (#304) #306

Open

style(float): apply ruff formatting to test_float_integration.py

ca1b057

TheRealAgentK approved these changes May 4, 2026

View reviewed changes

Shubhank-Jonnada merged commit a42bc7d into master May 4, 2026
3 checks passed

Shubhank-Jonnada deleted the fix/float-sdk-upgrade-v2 branch May 4, 2026 20:48

This was referenced May 4, 2026

feat(app-business-reviews): upgrade SDK to 2.0.0, add pytest unit tests #285

Open

fix(google-sheets): upgrade to SDK 2.0.0, fix Lambda crash on error paths #289

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(float): upgrade SDK to 2.0.0, add pytest unit tests#284

feat(float): upgrade SDK to 2.0.0, add pytest unit tests#284
Shubhank-Jonnada merged 12 commits intomasterfrom
fix/float-sdk-upgrade-v2

Shubhank-Jonnada commented Apr 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

TheRealAgentK left a comment

Uh oh!

TheRealAgentK left a comment

Uh oh!

Shubhank-Jonnada commented May 4, 2026

Uh oh!

TheRealAgentK left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Shubhank-Jonnada commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Results

Validation

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Integration Validation Results

Uh oh!

TheRealAgentK left a comment

Choose a reason for hiding this comment

Uh oh!

TheRealAgentK left a comment

Choose a reason for hiding this comment

🔴 Must fix — os.chdir(_parent) is process-global

🟡 Files to clean up

Uh oh!

Shubhank-Jonnada commented May 4, 2026

Uh oh!

TheRealAgentK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Shubhank-Jonnada commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading

🔴 Must fix — `os.chdir(_parent)` is process-global