Skip to content

Add Posts to Podcast post-publish promo#48902

Merged
mmtr merged 1 commit into
trunkfrom
add-post-publish-podcast-promo
May 19, 2026
Merged

Add Posts to Podcast post-publish promo#48902
mmtr merged 1 commit into
trunkfrom
add-post-publish-podcast-promo

Conversation

@mmtr
Copy link
Copy Markdown
Member

@mmtr mmtr commented May 18, 2026

Fixes #

Proposed changes

  • Add a post-publish editor modal from the Podcast package that invites eligible sites to try Posts to Podcast.
  • Gate the modal to non-P2 post editor sessions on sites with at least 5 posts published in the last month, including the post that was just published.
  • Require at least 50 visitors over the last 7 days before showing the modal.
  • Add focused eligibility tests and a podcast changelog entry.
Screenshot 2026-05-18 at 17 23 02

Related product discussion/links

  • N/A

Does this pull request change what data or activity we track or use?

No. It uses existing Jetpack Stats visitor counts server-side for eligibility and stores a local browser dismissal key.

Testing instructions

  • Run composer run phpunit -- --filter Post_Publish_Podcast_Promo_Test from projects/packages/podcast.
  • Run pnpm --dir projects/packages/podcast run build:blocks.
  • On a non-P2 site with Posts to Podcast enabled, make the site eligible: at least 5 posts in the last month and at least 50 visitors in the last 7 days.
  • Open a draft post in the block editor and publish it.
  • Confirm the Posts to Podcast modal appears after publishing.
  • Click the primary action and confirm it opens /wp-admin/upload.php?page=create-ai-podcast.
  • Dismiss the modal and confirm it does not show again for the same site/browser unless the local storage dismissal key is cleared.

@mmtr mmtr added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. labels May 18, 2026
@mmtr mmtr self-assigned this May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add-post-publish-podcast-promo branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add-post-publish-podcast-promo
bin/jetpack-downloader test jetpack-mu-wpcom-plugin add-post-publish-podcast-promo

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@mmtr mmtr force-pushed the add-post-publish-podcast-promo branch 6 times, most recently from 8e5648a to bbb2ca3 Compare May 18, 2026 10:59
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 18, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@mmtr mmtr force-pushed the add-post-publish-podcast-promo branch 16 times, most recently from 45d4be3 to 613a7d7 Compare May 18, 2026 15:20
@mmtr mmtr force-pushed the add-post-publish-podcast-promo branch 2 times, most recently from 610bb85 to 0c784e3 Compare May 18, 2026 15:56
@mmtr mmtr force-pushed the add-post-publish-podcast-promo branch from 0c784e3 to 6036514 Compare May 18, 2026 16:05
@mmtr mmtr merged commit dbc836f into trunk May 19, 2026
145 of 148 checks passed
@mmtr mmtr deleted the add-post-publish-podcast-promo branch May 19, 2026 07:40
@github-actions github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Review This PR is ready for review. labels May 19, 2026
&:focus {
box-shadow: 0 0 0 2px #3858e9;
}
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious; why this much custom styles and overrides on core componets? I bet 90% of would work via props or is reduntant anyway. Things like border-radius, font sizes etc are pretty surprising.

margin: 12px 0 0;
}

.jetpack-post-publish-podcast-promo-modal__actions {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could likely just use Stack component.

line-height: 1.3;
}

.jetpack-post-publish-podcast-promo-modal__description {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text component would likely do all this.

padding: 24px 32px 32px;
}

.jetpack-post-publish-podcast-promo-modal__title {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text component would likely do all this.

return (
<Modal
className="jetpack-post-publish-podcast-promo-modal"
title=""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title is important for accessibility, but not sure. 🤔

@mmtr
Copy link
Copy Markdown
Member Author

mmtr commented May 19, 2026

Thanks @simison! Addressed everything in #48950.

Copilot AI pushed a commit that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Podcast [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants