Add Posts to Podcast post-publish promo#48902
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
8e5648a to
bbb2ca3
Compare
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
45d4be3 to
613a7d7
Compare
610bb85 to
0c784e3
Compare
0c784e3 to
6036514
Compare
| &:focus { | ||
| box-shadow: 0 0 0 2px #3858e9; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm curious; why this much custom styles and overrides on core componets? I bet 90% of would work via props or is reduntant anyway. Things like border-radius, font sizes etc are pretty surprising.
| margin: 12px 0 0; | ||
| } | ||
|
|
||
| .jetpack-post-publish-podcast-promo-modal__actions { |
There was a problem hiding this comment.
You could likely just use Stack component.
| line-height: 1.3; | ||
| } | ||
|
|
||
| .jetpack-post-publish-podcast-promo-modal__description { |
There was a problem hiding this comment.
Text component would likely do all this.
| padding: 24px 32px 32px; | ||
| } | ||
|
|
||
| .jetpack-post-publish-podcast-promo-modal__title { |
There was a problem hiding this comment.
Text component would likely do all this.
| return ( | ||
| <Modal | ||
| className="jetpack-post-publish-podcast-promo-modal" | ||
| title="" |
There was a problem hiding this comment.
I think the title is important for accessibility, but not sure. 🤔
Fixes #
Proposed changes
Related product discussion/links
Does this pull request change what data or activity we track or use?
No. It uses existing Jetpack Stats visitor counts server-side for eligibility and stores a local browser dismissal key.
Testing instructions
composer run phpunit -- --filter Post_Publish_Podcast_Promo_Testfromprojects/packages/podcast.pnpm --dir projects/packages/podcast run build:blocks./wp-admin/upload.php?page=create-ai-podcast.