Refine post-publish podcast promo modal

[mmtr]

Fixes #

Proposed changes

• Refine the Posts to Podcast post-publish promo modal to use WordPress Text and VStack component primitives for its copy/layout.
• Remove redundant custom typography and action layout styles while preserving the custom hero artwork.
• Keep the visible modal heading as the accessible label without passing an empty modal title.

Related product discussion/links

• Follow-up to Add Posts to Podcast post-publish promo #48902.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

• Apply these changes to your WP.com site
• If your site doesn't meet the eligibility criteria for the modal to be visible (5 posts published in the last month, 50 visitors in the last week), modify the criteria with these filters:

add_filter( 'jetpack_posts_to_podcast_post_publish_promo_min_published_posts', function () {
	return 1;
} );

add_filter( 'jetpack_posts_to_podcast_post_publish_promo_min_visitors', function () {
	return 1;
} );

• Go to Posts > Add New
• Publish the post
• Confirm the Posts to Podcast promo modal appears.
• Confirm the modal body text is readable at normal paragraph size.
• Confirm the primary action spans the modal body width and opens /wp-admin/upload.php?page=create-ai-podcast.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the refine-post-publish-podcast-promo-modal branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin refine-post-publish-podcast-promo-modal

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

[simison]

You could consider Dialog and Button from @wordpress/ui though would be good to get package updated first (#48404) since there are a few fixes to Dialog in latest.

[mmtr]

Nice, I'll hold off until that gets merged.

[simison]

FYI #48404 is merged!

[simison]

This might break in future package updates (i.e. I wouldn't trust the CSS in the components as a stable API).

[mmtr]

Partially addressed. I removed the custom sizing/border/header button styling, but kept some minimal CSS overrides because the alternative would be to use the __experimentalHideHeader prop which seems less stable to me.

[simison]

ah in practise all those __experimentalHideHeader have been stable since they weren't unlocekd with lock()/unlock() mechanisms in Gutenberg, so I wouldn't worry about using it. :-) The new component from @wordpress/ui might also have what you need.