Add non-configurable exclusion list for known incompatible scripts#82
Closed
mreishus wants to merge 1 commit into
Closed
Add non-configurable exclusion list for known incompatible scripts#82mreishus wants to merge 1 commit into
mreishus wants to merge 1 commit into
Conversation
Contributor
Author
|
This should not be needed after #107 stops concat for script-loader-tag changed scripts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a hardcoded list of scripts known to break concatenation, starting with MonsterInsights which requires
type="module". Unlike the configurable exclusion list, this applies to all installations regardless of user settings.Background
MonsterInsights modifies its script tag to
type="module"viascript_loader_tagfilter, which breaks when concatenated because the concatenated version loses this attribute, and uses ES6 import statements that require it. Found here: 9017084-zd-a8cPossible Approach 1: Add to default exclusion list
Possible Approach 2: Detect module scripts by running
script_loader_tagfilter and checking results.Current Approach 3: Known incompatible list
Steps to Reproduce
Uncaught SyntaxError: import declarations may only appear at top level of module.To verify fix