Skip to content

Add non-configurable exclusion list for known incompatible scripts #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mreishus wants to merge 1 commit into from
Closed

Add non-configurable exclusion list for known incompatible scripts #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions page-optimize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,17 +136,25 @@ function page_optimize_js_load_mode_default() {
return '';
}

function page_optimize_js_known_incompatible() {
// Scripts that are known to break when concatenated
return [
'monsterinsights-vue-frontend', // Requires type="module"
];
}

function page_optimize_js_exclude_list() {
$exclude_list = get_option( 'page_optimize-js-exclude' );
$incompat_list = page_optimize_js_known_incompatible();
$exclude_list = get_option( 'page_optimize-js-exclude' );
if ( false === $exclude_list ) {
// Use the default since the option is not set
return page_optimize_js_exclude_list_default();
return array_merge( page_optimize_js_exclude_list_default(), $incompat_list );
}
if ( '' === $exclude_list ) {
return [];
return $incompat_list;
}

return explode( ',', $exclude_list );
return array_merge( $incompat_list, explode( ',', $exclude_list ) );
}

function page_optimize_js_exclude_list_default() {
Expand Down
Loading