Chat Design Consistency#313
Conversation
Avi0n
left a comment
Avi0n
left a comment
There was a problem hiding this comment.
I was debating on whether to accept this PR or not because I wasn't sure if I wanted the time to always show, but I ended up agreeing that it should always show.
There's some dead code clean up and L10n changes to the Settings footer, but I can do that in a followup. Please rebase your branch on dev and point the PR at dev, not main. Thanks!
| inputs: MessageBuildInputs, | ||
| envInputs: EnvInputs | ||
| ) -> MessageFooter { | ||
| let showHop = envInputs.showIncomingHopCount && message.isFloodRouted |
There was a problem hiding this comment.
Add !message.isOutgoing to conditions. Hops are currently appearing for outgoing messages without it.
|
@0PandaDEV I was going to do some more changes to the chat interface in an upcoming PR. Not sure if you have time to work on getting this rebased and ready for merge. I was going to wrap your changes into my PR (ill pull the commits so you retain credit for it) if not. |
|
Closing in favor of #355 |
3 participants
Updated the chat UI to be more consistent this includes making the time always visible on the bubble since I think that is pretty essential it also adds a spacer with the date between each new day and the general spacing is adjusted, so the content has more space to breathe.
I had the time turned on as optional field in the settings so its also visible on the before screenshot.