refactor: chat page#355
Merged
Merged
Conversation
bwees
force-pushed
the
refactor/chat-window
branch
from
July 3, 2026 16:44
ae311c6 to
b6f0c6d
Compare
bwees
marked this pull request as ready for review
July 3, 2026 17:21
bwees
force-pushed
the
refactor/chat-window
branch
3 times, most recently
from
July 12, 2026 23:26
8213d51 to
baaf9e4
Compare
claude is insane man....
Co-authored-by: PandaDEV <pandadev.net@proton.me>
bwees
force-pushed
the
refactor/chat-window
branch
from
July 14, 2026 03:21
a3cabd4 to
acd1553
Compare
- re-prime a warm coordinator when a message arrives for a closed chat, so reopening shows the full tail on the first frame instead of an offset-preserving append the view never scrolls for - ChatTiledView goes back to the library's append follow; drop the liveAppendGeneration/pendingBottomPin state machine - build link-preview fragments synchronously from the persisted caches at a reserved hero height, so cards keep one height while a chat opens - warm preview metadata and hero dimensions at arrival time from the background prime paths - drop EnvInputs.showInlineImages from the pagination test helper (the field no longer exists)
- Show the divider for any unread count and open chats scrolled to it - Remove the Jump to Unread button and its localized strings - Refresh DM prewarms from the store so the divider reflects the latest unread count - Bump MessagingUI to the fork revision that adds initial scroll targets
- route timeline mutations through ChatTimelineWriter; stale writers no-op, so a prewarm view model can't overwrite the live conversation with cold preview state - deny .prime binds while a chat is open; prime view models no longer subscribe to resolution streams - multicast dimension resolutions so two subscribers stop splitting the event stream - don't let a conversation's first load cancel its own preview fetches; a cancelled fetch resets .loading back to .idle - rebake rows that desynced from settled preview state and recover orphaned .loading entries - add tests for stale writers, role precedence, multicast delivery, and the load race
Owner
|
Thank you so much, you are awesome. It looks amazing!! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the styling and makes the chat view take full height on iOS 26
Overview of Changes
full height chat window in ios 26
Brought over changes from #313 (this can be closed once this merges)
Liquid glass bubble at top for chat name
Cleaned up styling of compose bar and icons. Send button now pops in when able to send (Signal Style).
Testing
Tested on ios 26, ios 18, and on a phyiscal iPad and iPhone
Tested on
Checklist
CONTRIBUTING.md