Skip to content

fix: path map hops banner#354

Merged
Avi0n merged 2 commits into
Avi0n:devfrom
bwees-forks:fix/path-map-hops-banner
Jul 6, 2026
Merged

fix: path map hops banner#354
Avi0n merged 2 commits into
Avi0n:devfrom
bwees-forks:fix/path-map-hops-banner

Conversation

@bwees

@bwees bwees commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Moves the path map banner pill to the bottom so it doesnt conflict with the scale element or compete with top bar

Overview of Changes

image

Testing

Simulator

Tested on

  • iOS [26, 18]
  • iPadOS [version]
  • macOS [version]

Checklist

  • This PR was discussed with the maintainer either via GitHub issue or other means (Also check if this PR is small enough not to need discussion e.g. typo fix)
  • I have read CONTRIBUTING.md
  • Testing steps are documented above.
  • This change is not low effort and I took the time to test it

@bwees
bwees changed the base branch from main to dev July 2, 2026 02:24
@Avi0n

Avi0n commented Jul 2, 2026

Copy link
Copy Markdown
Owner

This path distance banner pill is shared with the Trace Path Map results. Moving it to the bottom like this will hide it behind the "Run Trace" button.

What about keeping the distance banner at the top, but disabling the map ruler by setting showsScale: false in TracePathMapView.swift and MessagePathMapView.swift?

@bwees

bwees commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

I wonder if just replacing the "Path Map" sheet title with the details would suffice. You tapped on "Path Map" to get here so the title is kinda redundant

@Avi0n

Avi0n commented Jul 2, 2026

Copy link
Copy Markdown
Owner

I'm partial to the glass pill. I like seeing the map refract under it, haha. Is the issue that it seems too crowded at the top with the pill, even without the map scale?

@bwees

bwees commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Yeah I think it would be too crowded still. We can still do the glass pill at the top in the title bar (see the chat title in #355)

@Avi0n

Avi0n commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Ah yes, I like that idea.

@bwees
bwees force-pushed the fix/path-map-hops-banner branch from 90b7731 to 65099da Compare July 3, 2026 20:00
@bwees

bwees commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Just updated the bubble to be in the top bar (screenshot also updated). Let me know what you think!

@Avi0n

Avi0n commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Looks great, thanks!

@Avi0n
Avi0n merged commit 4581789 into Avi0n:dev Jul 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants