DeployWizard: Clarify target port label#658
Open
skoeva wants to merge 1 commit into
Open
Conversation
Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DeployWizard “Networking” step terminology to better align with Kubernetes concepts by labeling the target port field as the container/application port and clarifying the tooltip text.
Changes:
- Renames the “Target port” field label to “Container port (target port)” and updates the explanatory info text.
- Replaces the old i18n keys with new ones in
enand all supported locale translation files. - Adds new translation entries for the updated label and help text across locales.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/aks-desktop/src/components/DeployWizard/components/NetworkingStep.tsx | Updates the port field label + tooltip text to clarify “target port” terminology. |
| plugins/aks-desktop/locales/en/translation.json | Adds English strings for the new label + tooltip text and removes the old keys. |
| plugins/aks-desktop/locales/zh-Hant/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/zh-Hans/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/tr/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/sv/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/ru/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/pt-PT/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/pt-BR/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/pl/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/nl/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/ko/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/ja/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/it/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/id/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/hu/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/fr/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/es/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/de/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
| plugins/aks-desktop/locales/cs/translation.json | Introduces new keys but leaves values empty (currently drops existing translations for this UI text). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes clarify the networking step terminology by labeling the Kubernetes target port as the container port.
Fixes: #622
Summary
Container port (target port)Testing