Skip to content

Tiny trick that makes the bats run with less false positives#2379

Merged
seefood merged 12 commits intoBash-it:masterfrom
seefood:feature/update-actions
Apr 6, 2026
Merged

Tiny trick that makes the bats run with less false positives#2379
seefood merged 12 commits intoBash-it:masterfrom
seefood:feature/update-actions

Conversation

@seefood
Copy link
Copy Markdown
Contributor

@seefood seefood commented Apr 5, 2026

no more test runs complaining surprise number of skipped tests

@seefood seefood marked this pull request as ready for review April 5, 2026 07:29
@seefood
Copy link
Copy Markdown
Contributor Author

seefood commented Apr 5, 2026

@akinomyoga got remarks? should I lock versions down more tightly like before or is this ok?

Ira Abramov added 2 commits April 5, 2026 10:48
…nto feature/update-actions

* 'feature/update-actions' of github.com:seefood/bash-it:
  Default empty value for variable not defined
@akinomyoga
Copy link
Copy Markdown
Contributor

akinomyoga commented Apr 5, 2026

For GitHub Actions, it is considered better to freeze the commit ID in general, but I think the actions under the actions organization would be fine to use either approach.

For requirements.txt, I think it is better to fix the version. There is a possibility that something is broken by the upstream change. I think it is better to test the behavior when one wants to use it with newer versions of packages. By the way, have you tested the behavior for the present change of requirements.txt? If not, is there an explicit reason that you want to update them now?

@seefood
Copy link
Copy Markdown
Contributor Author

seefood commented Apr 5, 2026

well, the checkout@v4 is falling out of support in a few short months (interpreter too old), and I might as well use current python since 3.8 is also EOL, once upgraded those, sphinx broke because it was too old, etc. you can see it in the previous action runs from today.

I think I will just lock them with the latest that ran green for me and stick it at that?

Ira Abramov added 5 commits April 5, 2026 12:29
…nto feature/update-actions

* 'feature/update-actions' of github.com:seefood/bash-it:
  lock strict versions
…te-actions

* 'master' of github.com:Bash-it/bash-it:
  Update precommit hooks and github action with 10 days cooldown and pin to sha1 commit (Bash-it#2377)
@seefood seefood changed the title Upgrading actions that are using old interpreters and compilers. Tiny trick that makes the bats run with less false positives Apr 6, 2026
@seefood seefood merged commit 86e04e8 into Bash-it:master Apr 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants