[RFC] Add ability not to follow selected item in the table#40
Open
azat wants to merge 1 commit intoBonsaiDen:masterfrom
Open
[RFC] Add ability not to follow selected item in the table#40azat wants to merge 1 commit intoBonsaiDen:masterfrom
azat wants to merge 1 commit intoBonsaiDen:masterfrom
Conversation
It is not always useful to always select some item (i.e. first by sorting order, by the way it is not even how it works natively since sort_by() applied after, and you need to call set_selected_item(0) for this). Consider csysdig, by default when you did not press anything it stick to the first item by sort order, and only if you select something (Up/Down) then it will stick to this item in the table. And this behaviour is better, since if you did not focus any item you want to look at the items sorted by the sort order. And I also made the Home button to cancel this selection.
Author
|
Are there any interest in this? If yes, I can rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not always useful to always select some item (i.e. first by
sorting order, by the way it is not even how it works natively since
sort_by() applied after, and you need to call set_selected_item(0) for
this).
Consider csysdig, by default when you did not press anything it stick to
the first item by sort order, and only if you select something (Up/Down)
then it will stick to this item in the table.
And this behaviour is better, since if you did not focus any item you
want to look at the items sorted by the sort order.
And I also made the Home button to cancel this selection.