Open
Conversation
Collaborator
shafranovskyi-yevhenii
commented
Apr 2, 2026
shafranovskyi-yevhenii
commented
- Added Broadcasting API lib v0.57.
- Fixed BMP-8259 - NullPointerException in HandlerManager.
romanpbm
reviewed
Apr 2, 2026
Comment on lines
+39
to
+40
| if(isOnline){ | ||
| generators.add(generator.getGeneratorName()); |
romanpbm
reviewed
Apr 2, 2026
Comment on lines
+23
to
+25
| if(this.handlerManager == null) { | ||
| continue; | ||
| } |
romanpbm
reviewed
Apr 2, 2026
| private volatile HandlerManager handlerManager; | ||
| private final BlockingQueue<AbstractEvent> events = new LinkedBlockingQueue<>(); | ||
| private final AtomicBoolean isRun = new AtomicBoolean(true); | ||
| private final ExecutorService eventQueueReader = Executors.newSingleThreadExecutor(); |
Collaborator
There was a problem hiding this comment.
Could lead to the problem in case we enable/disable the addon. E.g. if you start the add-on and then remove the checkbox and then check it again - this executor service won't be initialized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.