-
Notifications
You must be signed in to change notification settings - Fork 16
0.1.5 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shafranovskyi-yevhenii
wants to merge
2
commits into
master
Choose a base branch
from
0.1.5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
0.1.5 #34
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,18 @@ | |
|
|
||
| public class EventLoop implements Closeable { | ||
|
|
||
| private HandlerManager handlerManager; | ||
| private volatile HandlerManager handlerManager; | ||
| private final BlockingQueue<AbstractEvent> events = new LinkedBlockingQueue<>(); | ||
| private final AtomicBoolean isRun = new AtomicBoolean(true); | ||
| private final ExecutorService eventQueueReader = Executors.newSingleThreadExecutor(); | ||
|
|
||
| public EventLoop() { | ||
| ExecutorService eventQueueReader = Executors.newSingleThreadExecutor(); | ||
| eventQueueReader.execute(() -> { | ||
| try { | ||
| while (isRun.get()) { | ||
| if(this.handlerManager == null) { | ||
| continue; | ||
| } | ||
|
Comment on lines
+23
to
+25
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Formatting issue |
||
| AbstractEvent event = events.poll(10, TimeUnit.SECONDS); | ||
| if (event == null) { | ||
| continue; | ||
|
|
@@ -41,6 +44,7 @@ public void pushEvent(AbstractEvent event) { | |
| @Override | ||
| public void close() throws IOException { | ||
| isRun.set(false); | ||
| eventQueueReader.shutdown(); | ||
| } | ||
|
|
||
| public void setHandlerManager(HandlerManager handlerManager) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,8 +34,14 @@ public void removeProvider(String providerName) { | |
| eventLoop.pushEvent(new ProviderStatusEvent(providerToGenerators)); | ||
| } | ||
|
|
||
| public void updateProvider(String providerName, List<GeneratorInfo> generators) { | ||
| providerToGenerators.put(providerName, generators.stream().map(JsonUtil::convertObjectToJsonString).toList()); | ||
| public void updateProvider(String providerName, GeneratorInfo generator, boolean isOnline) { | ||
| List<String> generators = providerToGenerators.get(providerName); | ||
| if(isOnline){ | ||
| generators.add(generator.getGeneratorName()); | ||
|
Comment on lines
+39
to
+40
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Formatting issue |
||
| } else { | ||
| generators.remove(generator.getGeneratorName()); | ||
| } | ||
|
|
||
| eventLoop.pushEvent(new ProviderStatusEvent(providerToGenerators)); | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could lead to the problem in case we enable/disable the addon. E.g. if you start the add-on and then remove the checkbox and then check it again - this executor service won't be initialized