Migrating from s2clientprotocol to pys2clientprotocol#239
Merged
BurnySc2 merged 6 commits intoBurnySc2:developfrom Mar 30, 2026
Merged
Migrating from s2clientprotocol to pys2clientprotocol#239BurnySc2 merged 6 commits intoBurnySc2:developfrom
BurnySc2 merged 6 commits intoBurnySc2:developfrom
Conversation
Owner
|
Works on my PC (linux+WINE). The github actions runners seem to show some improvements in their runtime. It may be because of this change. 35 minutes: https://github.com/BurnySc2/python-sc2/actions/runs/22142367633?pr=235 15 minutes: https://github.com/BurnySc2/python-sc2/actions/runs/22142367656?pr=235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, I made a package with prebuilt
_pb2.pyfiles, usingprotobuf >= 6:The package comes with
*.pyistubs so we could also remove them from this repo.edit: I think the failures are just because I pushed too quickly after releasing1.0.1; rerunning the pipeline should fix it