Skip to content

Migrating from s2clientprotocol to pys2clientprotocol#239

Merged
BurnySc2 merged 6 commits intoBurnySc2:developfrom
maxnus:pr-pys2clientprotocol
Mar 30, 2026
Merged

Migrating from s2clientprotocol to pys2clientprotocol#239
BurnySc2 merged 6 commits intoBurnySc2:developfrom
maxnus:pr-pys2clientprotocol

Conversation

@maxnus
Copy link
Copy Markdown
Contributor

@maxnus maxnus commented Mar 29, 2026

As discussed on Discord, I made a package with prebuilt _pb2.py files, using protobuf >= 6:

The package comes with *.pyi stubs so we could also remove them from this repo.

edit: I think the failures are just because I pushed too quickly after releasing 1.0.1; rerunning the pipeline should fix it

@BurnySc2
Copy link
Copy Markdown
Owner

Works on my PC (linux+WINE).
I couldn't verify the performance improvements though.

The github actions runners seem to show some improvements in their runtime. It may be because of this change.
Testsuite + docker runner: down from 35 to 18 minutes
New docker image creation: down from 15 to roughly 10 minutes

35 minutes: https://github.com/BurnySc2/python-sc2/actions/runs/22142367633?pr=235
down to 18 minutes: https://github.com/BurnySc2/python-sc2/actions/runs/22142367633?pr=235

15 minutes: https://github.com/BurnySc2/python-sc2/actions/runs/22142367656?pr=235
down to 10 minutes: https://github.com/BurnySc2/python-sc2/actions/runs/23719272754?pr=239

@BurnySc2 BurnySc2 merged commit a3ae5e3 into BurnySc2:develop Mar 30, 2026
43 checks passed
@maxnus maxnus deleted the pr-pys2clientprotocol branch March 30, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants