Skip to content

Migrating from s2clientprotocol to pys2clientprotocol #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurnySc2 merged 6 commits into from
Mar 30, 2026
+58 −34
Merged

Migrating from s2clientprotocol to pys2clientprotocol #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
527782c
Migrates from s2clientprotocol to pys2cientprotocol
maxnus Mar 29, 2026
fe5a7ef
Bump to support Python 3.9
maxnus Mar 29, 2026
a422bdb
Updates pys2clientprotocol to 1.0.2
maxnus Mar 29, 2026
6ffbac1
Updates uv.lock
maxnus Mar 29, 2026
f2bee73
Fixes protobuf test
maxnus Mar 29, 2026
c106d34
Removes unused import
maxnus Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ dependencies = [
"numpy>=2.1.0; python_full_version >= '3.13'",
"numpy>=2.0.0; python_full_version < '3.13'",
"portpicker>=1.6.0",
"protobuf<4.0.0",
"s2clientprotocol>=5.0.14.93333.0",
"pys2clientprotocol>=1.0.2",
"scipy>=1.16.3; python_full_version >= '3.14'",
"scipy>=1.14.1; python_full_version >= '3.13'",
"scipy>=1.7.1; python_full_version < '3.13'",
Expand All @@ -51,6 +50,7 @@ dev = [
"pillow>=12.0.0; python_full_version >= '3.14'",
"pillow>=11.0.0; python_full_version < '3.14'",
"pre-commit>=4.0.1",
"protobuf>=6,<8",
"pyglet>=2.0.20",
"pylint>=3.3.2",
# Type checker
Expand Down
7 changes: 2 additions & 5 deletions test/test_pickled_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import math
import pickle
import random
import sys
import unittest
from contextlib import suppress
from pathlib import Path
Expand Down Expand Up @@ -72,10 +71,8 @@ def get_map_specific_bot(map_path: Path) -> BotAI:


def test_protobuf_implementation():
"""Make sure that cpp is used as implementation"""
# Doesn't seem to be implemented in newer python versions
if sys.version_info < (3, 10) and sys.platform != "darwin":
assert api_implementation.Type() == "cpp"
"""Make sure that upb is used as implementation"""
assert api_implementation.Type() == "upb"


def test_bot_ai():
Expand Down
81 changes: 54 additions & 27 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading