[BUG]: fixed export of gs_ply and gs_video#255
Open
yash-jain221 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: gs_ply export incorrectly triggers gs_video + gs_video TypeError crash
Problem:
Requesting export_format="gs_ply" incorrectly also runs gs_video generation, which crashes. Related to #239.
Root Causes
api.py: Auto-appends "gs_video" to export format when any "gs" substring is detected (too broad)
utils/export/gs.py: write_videofile() wrapper fails when fps=None
Changes
api.py: Removed automatically adding gs_video in the export_format
utils/export/gs.py: Replaced write_videofile() with direct ffmpeg_write_video() call to bypass broken fps validation