Skip to content

[BUG]: fixed export of gs_ply and gs_video #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yash-jain221 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUG]: fixed export of gs_ply and gs_video #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/depth_anything_3/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,19 +224,6 @@ def inference(
# Export if requested
if export_dir is not None:

if "gs" in export_format:
if infer_gs and "gs_video" not in export_format:
export_format = f"{export_format}-gs_video"
if "gs_video" in export_format:
if "gs_video" not in export_kwargs:
export_kwargs["gs_video"] = {}
export_kwargs["gs_video"].update(
{
"extrinsics": render_exts,
"intrinsics": render_ixts,
"out_image_hw": render_hw,
}
)
# Add GLB export parameters
if "glb" in export_format:
if "glb" not in export_kwargs:
Expand Down
15 changes: 9 additions & 6 deletions src/depth_anything_3/utils/export/gs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import os
from typing import Literal, Optional
import moviepy.editor as mpy
from moviepy.video.io.ffmpeg_writer import ffmpeg_write_video
import torch

from depth_anything_3.model.utils.gs_renderer import run_renderer_in_chunk_w_trj_mode
Expand Down Expand Up @@ -119,11 +120,10 @@ def export_to_gs_video(
)

# save as video
preset = VIDEO_QUALITY_MAP[video_quality]["preset"]
ffmpeg_params = [
"-crf",
VIDEO_QUALITY_MAP[video_quality]["crf"],
"-preset",
VIDEO_QUALITY_MAP[video_quality]["preset"],
"-pix_fmt",
"yuv420p",
] # best compatibility
Expand All @@ -144,11 +144,14 @@ def export_to_gs_video(
output_name = f"{idx:04d}_{trj_mode}" if output_name is None else output_name
save_path = os.path.join(export_dir, f"gs_video/{output_name}.mp4")
# clip.write_videofile(save_path, codec="libx264", audio=False, bitrate="4000k")
clip.write_videofile(
save_path,
codec="libx264",
audio=False,
ffmpeg_write_video(
clip,
filename=save_path,
fps=fps,
codec="libx264",
preset=preset,
audiofile=None,
ffmpeg_params=ffmpeg_params,
logger="bar",
)
return