Merge shapes extensions into 3d-tiles-2.0 branch#112
Draft
weegeekps wants to merge 9 commits into
Draft
Conversation
lilleyse
reviewed
Jul 17, 2026
Collaborator
There was a problem hiding this comment.
The ellipsoid and cylinder extensions should specify implicit tiling subdivision rules.
They can be taken from
- https://github.com/CesiumGS/3d-tiles/tree/voxels/extensions/3DTILES_bounding_volume_cylinder#implicit-subdivision
- and I suppose https://github.com/CesiumGS/3d-tiles/tree/main/specification/ImplicitTiling#subdivision-scheme (the region section)
This presents a bit of a problem though - implicit tiling subdvision currently assumes z-up and these shapes are defined y-up. We'll need to resolve this somehow.
Collaborator
Author
There was a problem hiding this comment.
Let's talk about this next week when we're in person. I've resolved all of the other issues for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the shapes extensions from the 3D Tiles 1.1 and glTF 2.0 world into the 3D Tiles 2.0 and glTF 2.1 world.
Resolves:
For the most part these are 1:1 copies but there are some changes with each to make them align with new concepts.
I've left this PR in a draft state for now. Before I merge this and call it complete I want to resolve @jjhembd's concerns about antemeridians for the cylinder and ellipsoid extensions. I should be able to resolve those soon.