fix(enr): prevent RangeError crash on malformed ENR port values#333
Open
guha-rahul wants to merge 2 commits intoChainSafe:masterfrom
Open
fix(enr): prevent RangeError crash on malformed ENR port values#333guha-rahul wants to merge 2 commits intoChainSafe:masterfrom
guha-rahul wants to merge 2 commits intoChainSafe:masterfrom
Conversation
wemeetagain
reviewed
Mar 10, 2026
packages/enr/src/enr.ts
Outdated
| if (isUdp) { | ||
| const protoVal = isIpv6 ? this.kvs.get("udp6") : this.kvs.get("udp"); | ||
| if (!protoVal) { | ||
| if (!protoVal || protoVal.length < 2) { |
Member
There was a problem hiding this comment.
I think we want to still attempt to deserialize these values? I don't think its actually "malformed" here to use a single byte for a small port number, its just not really common.
Author
There was a problem hiding this comment.
I see, looking at the rust discv5 they seem to pad it and also some other checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a peer sends an ENR with a UDP/TCP/QUIC port value less than 2 bytes,
getLocationMultiaddr()passes it directly tobytesToValue()which callsDataView.getUint16()internally, throwing an unhandledRangeErrorthat crashes the process .Solution
Add a
protoVal.length < 2guard alongside the existing!protoValcheck for all three protocol branches (udp, tcp, quic) ingetLocationMultiaddr().