Skip to content

fix(enr): prevent RangeError crash on malformed ENR port values #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guha-rahul wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(enr): prevent RangeError crash on malformed ENR port values #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b24de00
guard against malformed ENR port values in getLocationMultiaddr
guha-rahul Mar 10, 2026
bb3bc88
add the other checks
guha-rahul Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/enr/src/enr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,13 @@ export function getProtocolValue(kvs: ReadonlyMap<ENRKey, ENRValue>, key: string
return undefined;
}

function normalizePortBytes(raw: Uint8Array | undefined): Uint8Array | undefined {
if (!raw || raw.length === 0 || raw.length > 2) return undefined;
if (raw[0] === 0) return undefined;
if (raw.length === 1) return new Uint8Array([0, raw[0]]);
return raw;
}

export function portToBuf(port: number): Uint8Array {
const buf = new Uint8Array(2);
buf[0] = port >> 8;
Expand Down Expand Up @@ -337,7 +344,7 @@ export abstract class BaseENR {
};

if (isUdp) {
const protoVal = isIpv6 ? this.kvs.get("udp6") : this.kvs.get("udp");
const protoVal = normalizePortBytes(isIpv6 ? this.kvs.get("udp6") : this.kvs.get("udp"));
if (!protoVal) {
return undefined;
}
Expand All @@ -349,7 +356,7 @@ export abstract class BaseENR {
return multiaddr([ipComponent, protoComponent]);
}
if (isTcp) {
const protoVal = isIpv6 ? this.kvs.get("tcp6") : this.kvs.get("tcp");
const protoVal = normalizePortBytes(isIpv6 ? this.kvs.get("tcp6") : this.kvs.get("tcp"));
if (!protoVal) {
return undefined;
}
Expand All @@ -361,7 +368,7 @@ export abstract class BaseENR {
return multiaddr([ipComponent, protoComponent]);
}
if (isQuic) {
const protoVal = isIpv6 ? this.kvs.get("quic6") : this.kvs.get("quic");
const protoVal = normalizePortBytes(isIpv6 ? this.kvs.get("quic6") : this.kvs.get("quic"));
if (!protoVal) {
return undefined;
}
Expand Down
Loading