fix(query): ensures 'passwords and secrets' queries do not flag fields in 'Proto' files (.proto) #8013
Open
cx-andre-pereira wants to merge 13 commits intoCheckmarx:masterfrom
Conversation
… stoping passwords and secrets flags on said files
… commented lines, new allow rules prevent proto files fields from flagging
…generic api key enforces trimmed line starting with 'access'
…Generic Token', improved 2 TF reousrce access rules, added missing positive test for 'Encryption Key' query, added samples (similar to neg28) in negative61 for TF resource access allow rule in 'Encryption Key' query (was also missing test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
Avoiding Proto File fields" allow rules.Proposed Changes
Added 4 new allow rules one for each of the following queries :
(?i)password\\s*=\\s*[1-9][0-9]{0,8}\\s*;(?i)private[_]?key\\s*=\\s*[1-9][0-9]{0,8}\\s*;(?i)token(_)?(key)?\\s*=\\s*[1-9][0-9]{0,8}\\s*;(?i)encryption[_]?key\\s*=\\s*[1-9][0-9]{0,8}\\s*;The regex associated with the queries all follow a very similar pattern designed to ensure as little headroom for
False Negativesas possible. The prefix to each regex is purely based on the main regex pattern associated with each query, then the suffix is identical between all regex :\\s*=\\s*[1-9][0-9]{0,8}\\s*;The suffix enforces the use of "=" and at least 1 integer value, additionally up to 8 more digits can be caught by the regex and finally there must be a semicolon at the end. All this is based on the ".proto" files syntax since it:
536,870,911;A new negative and positive test sample was added, along with those the "inspector_test" was expanded to include a sample of type "PROTO".
I submit this contribution under the Apache-2.0 license.