Add 61 missing BIOS token parameters#327
Merged
Merged
Conversation
ronger4
requested changes
May 11, 2026
Collaborator
ronger4
left a comment
ronger4
left a comment
There was a problem hiding this comment.
Please add tests with the new flags in the integration test file so we can verify those changes work properly through the integration test
Collaborator
|
Sanity fails on |
Collaborator
|
Merge conflict needs to be figured out here before I proceed to accepting and merging |
Collaborator
|
The other PRs are merged. This one is left. Conflicts needs to be resolved and then we can merge |
Adds AMD EPYC CBS tokens, Front NVMe slots 25-32, GPU Direct, Intel TDX, Memory/IO/PCIe, Security/ACPI, Serial/PCR, and speculative_lock_enable parameters. Closes CiscoDevNet#324 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add test_bios_policy_new_tokens with 30+ of the 61 new BIOS tokens covering Intel VT-d, GPU Direct, PCIe, memory/power, AMD CBS, POST, NVMe slot, and misc categories - Tests creation, idempotency, info verification, and update - Verify key API response fields (IntelVtForDirectedIo, ResizeBarSupport) - Add to cleanup lists and update policy count assertions
stevefulme1
force-pushed
the
fix/bios-missing-keys
branch
from
b3115b7 to
98e4543
Compare
…tern Upstream removed 'default: platform-default' from both DOCUMENTATION and argument_spec for BIOS parameters. Aligns new params with this convention to fix ansible-test sanity doc-default-does-not-match-spec errors.
dsoper2
pushed a commit
that referenced
this pull request
Jun 2, 2026
Add 9 BIOS parameters to DOCUMENTATION, argument_spec, and bios_property_map that were used in integration tests but never added to the module (cbs_cmn_cpu_avx512, cbs_cmn_mem_speed_ddr47xx2, gpu_direct_cpu1/2, sha384pcr_bank, slot_front_nvme25/26 link_speed and option_rom). Also add bios_property_map entries for 32 params from PR #327 that were added to DOCUMENTATION and argument_spec but omitted from the map, preventing them from being sent to the Intersight API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intersight_bios_policymodule as reported in BIOS module missing many keys from Intersight #324Test plan
ansible-test sanity --test validate-modulespassesansible-lintpasses (production profile)Closes #324
🤖 Generated with Claude Code