[EAGLE-7291] Update test_mixed_success_predict to handle V3 fail-fast#249
Merged
tiit-clarifai merged 6 commits intomasterfrom Apr 6, 2026
Merged
[EAGLE-7291] Update test_mixed_success_predict to handle V3 fail-fast#249tiit-clarifai merged 6 commits intomasterfrom
tiit-clarifai merged 6 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test_mixed_success_predict integration test to accommodate the different failure semantics between “V2” (partial processing with mixed status) and “V3” (fail-fast request rejection on early validation failures).
Changes:
- Replaces the second input from a non-existing image URL to an empty
Input()to trigger early validation failure deterministically. - Relaxes the top-level response status assertion to accept either
MIXED_STATUSorFAILURE. - Adjusts per-output expected status codes to reflect the new invalid-input scenario.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skypilot-catalog has no vms.csv for these providers, causing all their instance types to be flagged as missing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tiit-clarifai
changed the title
patricklundquist
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a V3 predict fails early during API-level validation, then the entire
request is rejected instead of doing partial processing like with V2 predicts.
Update the mixed status test to handle both V2 and V3 cases.