Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
env:
SLACK_ICON: "https://raw.githubusercontent.com/github/explore/2c7e603b797535e5ad8b4beb575ab3b7354666e1/topics/actions/actions.png"
SLACK_USERNAME: "GitHub Alerts"
SLACK_CHANNEL: "#grpc-client-repo-alerts"
SLACK_CHANNEL: "#alerts-grpc-client-repo"
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_COLOR: ${{ job.status }}
SLACK_MESSAGE: "Test failure"
Expand Down
15 changes: 9 additions & 6 deletions tests/client/test_image_predict.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,19 @@ def test_mixed_success_predict(channel_key):
resources_pb2.Input(
data=resources_pb2.Data(image=resources_pb2.Image(url=DOG_IMAGE_URL))
),
resources_pb2.Input(
data=resources_pb2.Data(image=resources_pb2.Image(url=NON_EXISTING_IMAGE_URL))
),
resources_pb2.Input(), # No data, gives a status code distinct from generic INPUT_FAILED.
],
)
response = post_model_outputs_and_maybe_allow_retries(
stub, request, metadata=metadata(pat=True)
)

assert response.status.code == status_code_pb2.MIXED_STATUS
# For V2 predict, the API will respond with MIXED_STATUS and one of the inputs will be SUCCESS.
# For V3 predict, the API does not do partial predicts on early failures, so it will respond with FAILURE and two failed inputs.
assert response.status.code in [status_code_pb2.MIXED_STATUS, status_code_pb2.FAILURE]

assert response.outputs[0].status.code == status_code_pb2.SUCCESS
assert response.outputs[1].status.code == status_code_pb2.INPUT_DOWNLOAD_FAILED
assert response.outputs[0].status.code in [
status_code_pb2.SUCCESS,
status_code_pb2.INPUT_FAILED,
]
assert response.outputs[1].status.code == status_code_pb2.INPUT_INVALID_ARGUMENT
Comment thread
tiit-clarifai marked this conversation as resolved.
8 changes: 8 additions & 0 deletions tests/instance_types/test_instance_types_ids.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@
'g4-standard-96',
'tpu7x-standard-1t',
'tpu7x-standard-4t',
's-2vcpu-2gb',
'gpu-h100x2-160gb',
'gpu-h100x4-320gb',
'gpu-mi300x1-192gb',
'gpu-mi300x8-1536gb',
'gpu-mi350x1-288gb-contracted',
'gpu-mi350x8-2304gb-contracted',
]


Expand Down Expand Up @@ -112,6 +119,7 @@ def fetch_skypilot_instance_types_by_provider(cloud_provider_id):
'aws': 'aws',
'gcp': 'gcp',
'azure': 'azure',
'digitalocean': 'do',
'local': 'local', # if local is supported
}

Expand Down
Loading