[T3061] FIX: incoming calls are now red in interaction resume

[Danielgergely]

• FIX: removed 'Phone' from communication_type not in [xxx]

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a display bug in the interaction resume view, ensuring that incoming phone calls are now properly highlighted as 'danger' (red). This change improves the visual clarity and immediate identification of incoming call interactions for users.

Highlights

• UI Fix: Resolved an issue where incoming phone calls were not correctly displayed with a 'danger' (red) decoration in the interaction resume view.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies interaction_resume.xml to apply decoration-danger styling to incoming phone calls. The reviewer noted that this change introduces an asymmetry in styling conditions between incoming and outgoing phone calls, potentially affecting maintainability. They suggest either adding an XML comment to clarify this logic or updating the decoration-success condition for consistency.

[gemini-code-assist]

While this change correctly makes incoming phone calls appear with decoration-danger, it introduces an inconsistency with the decoration-success rule on the next line, which can affect maintainability.

The conditions are now asymmetric for the 'Phone' communication type:

• decoration-danger (incoming): communication_type not in ['Mass', 'SMS'] (includes 'Phone')
• decoration-success (outgoing): communication_type not in ['Mass', 'Phone', 'SMS'] (excludes 'Phone')

This results in an incoming phone call being danger (red), while an outgoing phone call remains info (blue), unlike other non-Mass/SMS types which are success (green) when outgoing.

If this behavior is intentional, consider adding an XML comment to clarify the logic for future maintenance. If it's an oversight, the condition for decoration-success should be updated for consistency.