Skip to content

[T3061] FIX: incoming calls are now red in interaction resume #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecino merged 2 commits into from
Mar 26, 2026
Merged

[T3061] FIX: incoming calls are now red in interaction resume #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa9407
[T3061] FIX: incoming calls are now red in interaction resume
Danielgergely Mar 25, 2026
9c478e7
FIX: pre-commit
Danielgergely Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion interaction_resume/views/interaction_resume.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
js_class="button_in_tree"
decoration-muted="communication_type == 'Mass'"
decoration-info="communication_type in ['Phone', 'SMS']"
decoration-danger="direction == 'in' and communication_type not in ['Mass', 'Phone', 'SMS']"
decoration-danger="direction == 'in' and communication_type not in ['Mass', 'SMS']"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly makes incoming phone calls appear with decoration-danger, it introduces an inconsistency with the decoration-success rule on the next line, which can affect maintainability.

The conditions are now asymmetric for the 'Phone' communication type:

  • decoration-danger (incoming): communication_type not in ['Mass', 'SMS'] (includes 'Phone')
  • decoration-success (outgoing): communication_type not in ['Mass', 'Phone', 'SMS'] (excludes 'Phone')

This results in an incoming phone call being danger (red), while an outgoing phone call remains info (blue), unlike other non-Mass/SMS types which are success (green) when outgoing.

If this behavior is intentional, consider adding an XML comment to clarify the logic for future maintenance. If it's an oversight, the condition for decoration-success should be updated for consistency.

decoration-success="direction == 'out' and communication_type not in ['Mass', 'Phone', 'SMS']"
edit="0"
create="0"
Expand Down
2 changes: 1 addition & 1 deletion intervention_compassion/data/account.analytic.group.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ analytic_group_unrestricted,unrestricted fund,analytic_group_fund
analytic_group_christmas,christmas fund,analytic_group_fund
analytic_group_local,local fund,analytic_group_fund
analytic_group_ldp,ldp fund,analytic_group_fund
analytic_group_usp,unsponsored fund,analytic_group_fund
analytic_group_usp,unsponsored fund,analytic_group_fund
Loading