Skip to content

fix(cli): pluralize model counts correctly#253

Open
felipegr0ssi wants to merge 1 commit into
CortexLM:mainfrom
felipegr0ssi:fix/model-count-label
Open

fix(cli): pluralize model counts correctly#253
felipegr0ssi wants to merge 1 commit into
CortexLM:mainfrom
felipegr0ssi:fix/model-count-label

Conversation

@felipegr0ssi
Copy link
Copy Markdown

Summary

  • Use model when a provider has exactly one model and models otherwise in cortex models output.
  • Add a small unit test for the count label helper covering 0, 1, and 2.

Related bounty report: PlatformNetwork/bounty-challenge#53201

Validation

  • git diff --check

Note: cargo / rustc are not installed in my local Windows environment, so I could not run Rust tests locally. The added helper is covered by a focused unit test in the patch.

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants