Skip to content

fix(cli): pluralize model counts correctly #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felipegr0ssi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): pluralize model counts correctly #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/cortex-cli/src/models_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,9 @@ async fn run_list(
};

for (provider, models) in by_provider {
println!("\n{} ({} models)", provider, models.len());
let model_count = models.len();
let model_label = model_count_label(model_count);
println!("\n{} ({} {})", provider, model_count, model_label);
println!("{}", "-".repeat(40));
println!(
"{:<width$} {:^6} {:^12} {:^8} {:^6}",
Expand Down Expand Up @@ -603,6 +605,14 @@ async fn run_list(
Ok(())
}

fn model_count_label(count: usize) -> &'static str {
if count == 1 {
"model"
} else {
"models"
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down Expand Up @@ -631,6 +641,13 @@ mod tests {
assert_eq!(result, ModelSortOrder::Provider);
}

#[test]
fn test_model_count_label() {
assert_eq!(model_count_label(0), "models");
assert_eq!(model_count_label(1), "model");
assert_eq!(model_count_label(2), "models");
}

#[test]
fn test_model_sort_order_from_str_case_insensitive() {
let upper: ModelSortOrder = "ID".parse().expect("parsing 'ID' should succeed");
Expand Down