Skip to content

Add typed radio command form fields with docs, stories, and CI test fixes#2229

Merged
einari merged 4 commits into
mainfrom
copilot/add-radio-button-command-fields
May 21, 2026
Merged

Add typed radio command form fields with docs, stories, and CI test fixes#2229
einari merged 4 commits into
mainfrom
copilot/add-radio-button-command-fields

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

Summary

Adds typed radio field support to CommandForm, including documentation and Storybook coverage for the new field types, and fixes the JavaScript CI regressions uncovered during review.

Added

Changed

<RadioGroupField
    value={(c: MyCommand) => c.role}
    options={[
        { value: 'Reader', label: 'Reader' },
        { value: 'Admin', label: 'Admin' }
    ]}
/>

Fixed

Removed

  • None

Security

  • None

Deprecated

  • None

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/ad2aa68a-002d-4784-bed2-9e113d3e2521

Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copilot AI changed the title [WIP] Add radio button groups as command fields Add typed radio command form fields May 21, 2026
Copilot finished work on behalf of einari May 21, 2026 09:28
Copilot AI requested a review from einari May 21, 2026 09:28
@einari
Copy link
Copy Markdown
Contributor

einari commented May 21, 2026

@copilot Add documentation and Storybook stories for the new field type

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/f582b1f9-56c5-45aa-a028-5e0491cea41f

Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 21, 2026

@copilot Add documentation and Storybook stories for the new field type

Added the CommandForm field docs for RadioButtonField and RadioGroupField, wired them into the field-types TOC, and added a RadioFields Storybook story in commit 394be01. Screenshot of the built Storybook story: /tmp/radio-fields-storybook.png.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • example.com
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/Arc/Arc/node_modules/vitest/vitest.mjs run commands/CommandForm (dns block)
  • storybook.js.org
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/Arc/Arc/node_modules/storybook/dist/bin/dispatcher.js build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Add typed radio command form fields Add typed radio command form fields with docs and stories May 21, 2026
Copilot finished work on behalf of einari May 21, 2026 10:02
@github-actions
Copy link
Copy Markdown

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.24.20

Agent-Logs-Url: https://github.com/Cratis/Arc/sessions/e376f340-4a88-4c3e-818e-b5ac84bffbde

Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 21, 2026

@copilot We're seeing some serious regressions in the JavaScript build that has to be fixed

https://productionresultssa9.blob.core.windows.net/actions-results/024cfb87-9c4f-41cf-8342-db415ae061f9/w...

Fixed in 7dce771. The JavaScript build failure was coming from queries/for_useChangeStream/* tests sharing a fake observable query across files during the full Arc.React CI run, so I isolated those test fakes per file and kept the callback setup deterministic. I re-ran yarn workspace @cratis/arc.react ci successfully. No UI changed in this fix, so there isn’t a new screenshot to attach.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • example.com
    • Triggering command: /usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/Arc/Arc/node_modules/vitest/vitest.mjs run (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Add typed radio command form fields with docs and stories Add typed radio command form fields with docs, stories, and CI test fixes May 21, 2026
Copilot finished work on behalf of einari May 21, 2026 11:07
@github-actions
Copy link
Copy Markdown

NuGet packages for this PR, e.g. Cratis.Arc:
https://github.com/cratis/arc/packages/1655206?version=20.24.22

Copilot AI added a commit that referenced this pull request May 21, 2026
Co-authored-by: einari <134365+einari@users.noreply.github.com>
einari added a commit that referenced this pull request May 21, 2026
@einari einari merged commit ce0f566 into main May 21, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Radio button / Radio button groups as command fields

2 participants